From a876226bdf2834576c5b2eba371df227cd925eaa Mon Sep 17 00:00:00 2001 From: Mart van de Ven Date: Fri, 31 Oct 2025 22:18:49 +0800 Subject: [PATCH 1/2] Remove 'macroregion','macrocounty', and 'borough' as they no longer seem to be used in the actual releases. --- schema/divisions/defs.yaml | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/schema/divisions/defs.yaml b/schema/divisions/defs.yaml index 4b3e3ec5d..31b1d852d 100644 --- a/schema/divisions/defs.yaml +++ b/schema/divisions/defs.yaml @@ -18,17 +18,11 @@ description: Common schema definitions for divisions theme # for defence, passport control, etc., e.g. # Puerto Rico. - - macroregion # A bundle of regions, e.g. England, Scotland, - # Île-de-France. These exist mainly in Europe. - - region # A state, province, region, etc. Largest # sub-country administrative unit in most # countries, except those that have dependencies # or macro-regions. - - macrocounty # A bundle of counties, e.g. Inverness. These - # exist mainly in Europe. - - county # Largest sub-region administrative unit in most # countries, unless they have macrocounties. @@ -42,9 +36,6 @@ description: Common schema definitions for divisions theme - locality # A populated place that may or may not have its # own administrative authority. - - borough # A local government unit subordinate to a - # locality. - - macrohood # A super-neighborhood that contains smaller # divisions of type neighborhood, e.g. BoCaCa # (Boerum Hill, Cobble Hill, and Carroll @@ -63,7 +54,7 @@ description: Common schema definitions for divisions theme each subsequent entry, if any, being a division that is a direct child of the previous entry; and the last entry representing the division that contains the hierarchy. - + For example, a hierarchy for the United States is simply [United States]. A hierarchy for the U.S. state of New Hampshire would be [United States, New Hampshire], and a hierarchy for the From 8e07ee3ae9403e259860d6912a9022ea839a6487 Mon Sep 17 00:00:00 2001 From: Mart van de Ven Date: Fri, 31 Oct 2025 22:29:05 +0800 Subject: [PATCH 2/2] Edit examples to reflect removal of 'borough', 'macroregion', and 'macrocounty' subtype values --- .../divisions/division_boundary/missing-class.yaml | 2 +- .../divisions/division_boundary/missing-division_ids.yaml | 2 +- examples/divisions/division/hierarchies-multiple.yaml | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/counterexamples/divisions/division_boundary/missing-class.yaml b/counterexamples/divisions/division_boundary/missing-class.yaml index 287516eb2..4df2e3ea6 100644 --- a/counterexamples/divisions/division_boundary/missing-class.yaml +++ b/counterexamples/divisions/division_boundary/missing-class.yaml @@ -8,7 +8,7 @@ properties: theme: divisions type: division_boundary version: 0 - subtype: macroregion + subtype: region is_territorial: true is_land: false country: "XX" diff --git a/counterexamples/divisions/division_boundary/missing-division_ids.yaml b/counterexamples/divisions/division_boundary/missing-division_ids.yaml index 96f014e57..08cc44819 100644 --- a/counterexamples/divisions/division_boundary/missing-division_ids.yaml +++ b/counterexamples/divisions/division_boundary/missing-division_ids.yaml @@ -11,7 +11,7 @@ properties: class: land is_territorial: false is_land: true - subtype: macrocounty + subtype: county country: "XX" ext_expected_errors: - "missing property 'division_ids'" diff --git a/examples/divisions/division/hierarchies-multiple.yaml b/examples/divisions/division/hierarchies-multiple.yaml index 88f9f1584..fde2701d6 100644 --- a/examples/divisions/division/hierarchies-multiple.yaml +++ b/examples/divisions/division/hierarchies-multiple.yaml @@ -8,7 +8,7 @@ properties: theme: divisions type: division version: 0 - subtype: borough + subtype: macrohood local_type: en: borough names: @@ -26,7 +26,7 @@ properties: subtype: locality name: New York City - division_id: example:division:borough:bronx - subtype: borough + subtype: macrohood name: The Bronx - - division_id: example:division:country:us subtype: country @@ -38,6 +38,6 @@ properties: subtype: county name: Bronx County - division_id: example:division:borough:bronx - subtype: borough + subtype: macrohood name: The Bronx parent_division_id: example:division:locality:nyc # Parent from default hierarchy.