Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing [io] from Pars argument #28

Closed
wlmb opened this issue Dec 9, 2024 · 1 comment
Closed

Missing [io] from Pars argument #28

wlmb opened this issue Dec 9, 2024 · 1 comment

Comments

@wlmb
Copy link
Contributor

wlmb commented Dec 9, 2024

gtsv from PDL::LinearAlgebra::Complex and maybe other routines (I haven't checked yet) modify some of their arguments, though they do not declare them as [io] arguments.
mohawk2 added a commit that referenced this issue Dec 29, 2024
@mohawk2
fix some Pars so their [io] or [o] matches docs enough - #28
7ddcd97
mohawk2 added a commit that referenced this issue Dec 29, 2024
@mohawk2
add note in Changes that Pars changes affect return signatures - #28
9215888
mohawk2 added a commit that referenced this issue Dec 29, 2024
@mohawk2
mgeigen use new_or_inplace, add [io] to ggev A and B Pars - #28
52be204
@mohawk2
Copy link
Member

mohawk2 commented Dec 29, 2024

See the Changes file for the ones that did need changing - it was a few, actually! I've addressed this now because it connects with the remaining type-conversion issues in main PDL.

Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mohawk2 @wlmb