Skip to content

Commit 4e539f1

Browse files
authored
Fix false positives when validating parameter table (#174)
For single-row validation, don't pass any other dataframes/models to `petab.check_parameter_df` to avoid false positives due to the incomplete parameter table. Closes #126.
1 parent 67e7aa2 commit 4e539f1

File tree

1 file changed

+19
-11
lines changed

1 file changed

+19
-11
lines changed

src/petab_gui/controllers/table_controllers.py

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1284,19 +1284,27 @@ def check_petab_lint(
12841284
col_name: str = None,
12851285
):
12861286
"""Check a number of rows of the model with petablint."""
1287+
# Validate full parameter table
12871288
if row_data is None:
12881289
row_data = self.model.get_df()
1289-
observable_df = self.mother_controller.model.observable.get_df()
1290-
measurement_df = self.mother_controller.model.measurement.get_df()
1291-
condition_df = self.mother_controller.model.condition.get_df()
1292-
sbml_model = self.mother_controller.model.sbml.get_current_sbml_model()
1293-
return petab.check_parameter_df(
1294-
row_data,
1295-
observable_df=observable_df,
1296-
measurement_df=measurement_df,
1297-
condition_df=condition_df,
1298-
model=sbml_model,
1299-
)
1290+
observable_df = self.mother_controller.model.observable.get_df()
1291+
measurement_df = self.mother_controller.model.measurement.get_df()
1292+
condition_df = self.mother_controller.model.condition.get_df()
1293+
sbml_model = (
1294+
self.mother_controller.model.sbml.get_current_sbml_model()
1295+
)
1296+
return petab.check_parameter_df(
1297+
row_data,
1298+
observable_df=observable_df,
1299+
measurement_df=measurement_df,
1300+
condition_df=condition_df,
1301+
model=sbml_model,
1302+
)
1303+
1304+
# Validate a single parameter row
1305+
# In this case, we don't pass any other dataframes/models to avoid
1306+
# false positives due to the incomplete parameter table.
1307+
return petab.check_parameter_df(row_data)
13001308

13011309

13021310
class VisualizationController(TableController):

0 commit comments

Comments
 (0)