Skip to content

Commit 010ae31

Browse files
committed
fix(Heaters): Update Heaters
- support updated honeybee-ph (v1.28.10) hot water heat pumps - format `isort`, `black` - update requirements version - update tests
1 parent 69b8c43 commit 010ae31

File tree

12 files changed

+9893
-9894
lines changed

12 files changed

+9893
-9894
lines changed

PHX/from_HBJSON/create_shw_devices.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,9 @@ def build_phx_hw_heater(
8787
"PhHvacHotWaterHeaterBoiler": hvac.PhxHeaterBoilerFossil,
8888
"PhHvacHotWaterHeaterBoilerWood": hvac.PhxHeaterBoilerWood,
8989
"PhHvacHotWaterHeaterDistrict": hvac.PhxHeaterDistrictHeat,
90-
"PhHvacHotWaterHeaterHeatPump": hvac.PhxHeatPumpHotWater,
90+
"PhHvacHotWaterHeaterHeatPump_Annual": hvac.PhxHeatPumpAnnual,
91+
"PhHvacHotWaterHeaterHeatPump_Monthly": hvac.PhxHeatPumpMonthly,
92+
"PhHvacHotWaterHeaterHeatPump_Inside": hvac.PhxHeatPumpHotWater,
9193
}
9294

9395
# -- Build the basic heater and set basic data

PHX/from_WUFI_XML/phx_schemas.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1549,7 +1549,7 @@ def _PhxDevice_HeatPump_HotWater(_data: wufi_xml.WufiDevice) -> PhxHeatPumpHotWa
15491549

15501550
phx_obj.display_name = _data.Name or "unnamed_hot_water_heat_pump"
15511551
phx_obj.params.annual_COP = _data.PH_Parameters.AnnualCOP
1552-
phx_obj.params.annual_system_perf_ratio = _data.PH_Parameters.TotalSystemPerformanceRatioHeatGenerator
1552+
phx_obj.params.total_system_perf_ratio = _data.PH_Parameters.TotalSystemPerformanceRatioHeatGenerator
15531553
phx_obj.params.annual_energy_factor = _data.PH_Parameters.HPWH_EF
15541554
return phx_obj
15551555

PHX/model/hvac/heat_pumps.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ def ambient_temp_2(self, value: Optional[float]) -> None:
114114
class PhxHeatPumpHotWaterParams(_base.PhxMechanicalDeviceParams):
115115
hp_type: HeatPumpType = field(init=False, default=HeatPumpType.HOT_WATER)
116116
annual_COP: Optional[float] = None
117-
annual_system_perf_ratio: Optional[float] = None
117+
total_system_perf_ratio: Optional[float] = None
118118
annual_energy_factor: Optional[float] = None
119119

120120

PHX/to_WUFI_XML/xml_schemas.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1261,7 +1261,7 @@ def _DeviceHeaterHeatPumpPhParamsHotWater(
12611261
XML_Node("AuxiliaryEnergyDHW", _p.aux_energy_dhw),
12621262
XML_Node("InConditionedSpace", _p.in_conditioned_space),
12631263
XML_Node("AnnualCOP", _p.annual_COP),
1264-
XML_Node("TotalSystemPerformanceRatioHeatGenerator", _p.annual_system_perf_ratio),
1264+
XML_Node("TotalSystemPerformanceRatioHeatGenerator", _p.total_system_perf_ratio),
12651265
XML_Node("HPWH_EF", _p.annual_energy_factor),
12661266
XML_Node("HPType", _p.hp_type.value),
12671267
]

requirements.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
honeybee-core>=1.58.14
2-
honeybee-energy>=1.105.64
3-
honeybee-ph>=1.28.6
2+
honeybee-energy>=1.106.2
3+
honeybee-ph>=1.28.10
44
pydantic<2.0
5-
PH-units>=1.5.8
5+
PH-units>=1.5.9
66
rich
77
xlwings
88
lxml

tests/_source_gh/hbph_test_models.gh

-5.3 KB
Binary file not shown.

0 commit comments

Comments
 (0)