From 636a01761242896d8c70ab1d363aa0b3144e746d Mon Sep 17 00:00:00 2001 From: haidv Date: Wed, 16 Jul 2025 15:11:28 +0700 Subject: [PATCH 1/2] feat: Add Nova 5 compatibility - Update Laravel Nova requirement to ^5.0 - Update PHP requirement to ^8.1 - Update arcanedev/log-viewer to ^11.0 - Update Tool.php to use NovaRequest type hint - Update test dependencies for Laravel 11 compatibility --- composer.json | 10 +++++----- src/Tool.php | 7 +++---- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/composer.json b/composer.json index 0ba0257..7025256 100644 --- a/composer.json +++ b/composer.json @@ -13,13 +13,13 @@ } ], "require": { - "php": "^7.3|^8.0", - "laravel/nova": "^4.0", - "arcanedev/log-viewer": "*" + "php": "^8.1", + "laravel/nova": "^5.0", + "arcanedev/log-viewer": "^11.0" }, "require-dev": { - "orchestra/testbench": "^3.6", - "phpunit/phpunit": "7.1" + "orchestra/testbench": "^8.0|^9.0", + "phpunit/phpunit": "^10.0|^11.0" }, "autoload": { "psr-4": { diff --git a/src/Tool.php b/src/Tool.php index 5c2c6d6..59cf0ab 100644 --- a/src/Tool.php +++ b/src/Tool.php @@ -2,8 +2,7 @@ namespace PhpJunior\NovaLogViewer; -use Illuminate\Http\Request; -use Laravel\Nova\Menu\MenuGroup; +use Laravel\Nova\Http\Requests\NovaRequest; use Laravel\Nova\Menu\MenuItem; use Laravel\Nova\Menu\MenuSection; use Laravel\Nova\Nova; @@ -25,10 +24,10 @@ public function boot() /** * Build the menu that renders the navigation links for the tool. * - * @param \Illuminate\Http\Request $request + * @param \Laravel\Nova\Http\Requests\NovaRequest $request * @return mixed */ - public function menu(Request $request) + public function menu(NovaRequest $request) { return MenuSection::make('Log Viewer', [ MenuItem::link('Dashboard', '/nova-logs/dashboard'), From d211e737f45e9580135e7da9332a337bd79daab2 Mon Sep 17 00:00:00 2001 From: haidv Date: Wed, 16 Jul 2025 16:15:40 +0700 Subject: [PATCH 2/2] fix: Use Illuminate\Http\Request instead of NovaRequest - Fix method signature compatibility with Laravel\Nova\Tool::menu() - Change from NovaRequest to Request to match parent class signature - This resolves the fatal error about incompatible method declarations --- src/Tool.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Tool.php b/src/Tool.php index 59cf0ab..b2b31c6 100644 --- a/src/Tool.php +++ b/src/Tool.php @@ -2,7 +2,7 @@ namespace PhpJunior\NovaLogViewer; -use Laravel\Nova\Http\Requests\NovaRequest; +use Illuminate\Http\Request; use Laravel\Nova\Menu\MenuItem; use Laravel\Nova\Menu\MenuSection; use Laravel\Nova\Nova; @@ -24,10 +24,10 @@ public function boot() /** * Build the menu that renders the navigation links for the tool. * - * @param \Laravel\Nova\Http\Requests\NovaRequest $request + * @param \Illuminate\Http\Request $request * @return mixed */ - public function menu(NovaRequest $request) + public function menu(Request $request) { return MenuSection::make('Log Viewer', [ MenuItem::link('Dashboard', '/nova-logs/dashboard'),