Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xlim and ylim parameter documentation #67

Open
efletcherPIFSC opened this issue Jan 4, 2023 · 1 comment
Open

xlim and ylim parameter documentation #67

efletcherPIFSC opened this issue Jan 4, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation question Further information is requested topic: ss-plots Relating to ssplot functions derived from r4ss
Milestone

Comments

@efletcherPIFSC
Copy link
Collaborator

efletcherPIFSC commented Jan 4, 2023

SSplotModelComp, SSplotEnsemble, SSplotHCXval, SSplotJABBAres, SSplotRetro, SSplotRunsTest has the xlim parameter, but it is documented differently.

xlim SSplot parameters

  • SSplotModelComp
    • xlim = "default"
    • @param xlim Optional, values for x-axis range of years to display on plot. Default = "default" displays all years of available data. (currently not used)
  • SSplotEnsemble
    • xlim = NULL
    • @param xlim Optional, years to use for x-axis. Default NULL uses all years available.
  • SSplotHCXval
    • xlim = "default"
    • @param xlim Optional, values for x-axis range of years to display on plot. Default = "default" displays all years of available data. (currently not in use)
  • SSplotJABBAres
    • xlim = "default"
    • @param xlim Optional, values for x-axis range of years to display on plot.
  • SSplotRetro
    • xlim = NULL
    • @param xlim optional xlim, which overwrites xmin
  • SSplotRunsTest
    • xlim = "default"
    • @param xlim Optional, values for x-axis range of years to display on plot. Default = "default" displays all years of available data.

The different methods used in each SSplot vary the usage of xlim. Some of the functions do not implement the parameter. #69

ylim SSplot parameters

ylim documentation is similar, but limited to a set of SSplots

  • SSplotJABBAres and SSplotRunsTest lists the ylim parameter and sets it to "default"
    • SSplotJABBAres: @param ylim Optional, min and max values for the ylim to override the "default" value (-0.7, 0.5)
    • SSplotRunsTest: @param ylim Optional, values for y-axis range to display on plot. Default = "default" will range from -1 to 1.
  • SSplotRetro and SSplotHCXval lists the ylim parameter and sets it to NULL.
    • SSplotRetro: @param ylim option to specify ylim range
    • SSplotHCXval: @param ylim will over-write ylimAdj if specified
  • SSplotModelcomp and SSplotEnsemble do not list ylim as an parameter. It is defined within the function
@efletcherPIFSC efletcherPIFSC added documentation Improvements or additions to documentation topic: ss-plots Relating to ssplot functions derived from r4ss labels Jan 4, 2023
@efletcherPIFSC efletcherPIFSC changed the title xlim parameter documentation: NULL and default xlim and ylim parameter documentation Jan 4, 2023
@efletcherPIFSC efletcherPIFSC added this to the ss3diags 2.2.0 milestone Jan 17, 2023
@efletcherPIFSC efletcherPIFSC added the question Further information is requested label Jan 18, 2023
@efletcherPIFSC
Copy link
Collaborator Author

Created SSplotGeneric to inherit common SSplot parameters (#94)

#' @param xlim
#' Optional, years to use for x-axis. Default value NULL (or "default"),
#' uses all years available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation question Further information is requested topic: ss-plots Relating to ssplot functions derived from r4ss
Projects
Status: No status
Development

No branches or pull requests

2 participants