Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retrospective checks #89

Closed
efletcherPIFSC opened this issue Jul 10, 2023 · 2 comments · Fixed by #88
Closed

retrospective checks #89

efletcherPIFSC opened this issue Jul 10, 2023 · 2 comments · Fixed by #88
Labels
bug Something isn't working topic: model-diagnostics topic: Stock-Synthesis Specific for Stock-Synthesis Models or its functionality topic: test workflow For automated testing (github actions) and testthat

Comments

@efletcherPIFSC
Copy link
Collaborator

@MOshima-PIFSC

When checking #88 codebase,
R package checker found errors with the test files, however this was because stock synthesis wasn't installed in my system,

> ## Run retrospectives
> r4ss::retro(dir = run_tmp, oldsubdir = "", newsubdir = "retrospectives", years = 0:-3, show_in_console = FALSE)
Error in check_exe(exe = exe, dir = olddir, verbose = verbose) : 
  ss.exe not found in C:\Users\ERIC~1.FLE\AppData\Local\Temp\Rtmpi0C64v/working_dir\RtmpMZOYd9/test-runs nor in the path.
Calls: <Anonymous> -> check_exe
Execution halted

"run retrospectives" could be test_that module that could detect if the stock synthesis executable is on the system.
@efletcherPIFSC efletcherPIFSC added bug Something isn't working topic: test workflow For automated testing (github actions) and testthat topic: Stock-Synthesis Specific for Stock-Synthesis Models or its functionality topic: model-diagnostics labels Jul 10, 2023
@MOshima-PIFSC
Copy link
Contributor

@efletcherPIFSC I will fix this and add into the PR.

MOshima-PIFSC added a commit that referenced this issue Jul 11, 2023
@MOshima-PIFSC
add skip if for tests for retrospective checks #89
5914793
@MOshima-PIFSC
Copy link
Contributor

@efletcherPIFSC I added some skip if statements to the tests. Please see if these work for you now.
Thanks!

@efletcherPIFSC efletcherPIFSC mentioned this issue Jul 11, 2023
Merged
@efletcherPIFSC efletcherPIFSC linked a pull request Jul 11, 2023 that will close this issue
Feat update testing fixtures #88
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working topic: model-diagnostics topic: Stock-Synthesis Specific for Stock-Synthesis Models or its functionality topic: test workflow For automated testing (github actions) and testthat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat update testing fixtures PIFSCstockassessments/ss3diags
2 participants
@efletcherPIFSC @MOshima-PIFSC