Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: tests are failing #97

Closed
MOshima-PIFSC opened this issue Jan 17, 2024 · 0 comments · Fixed by #98
Closed

BUG: tests are failing #97

MOshima-PIFSC opened this issue Jan 17, 2024 · 0 comments · Fixed by #98
Assignees
@MOshima-PIFSC
Labels
bug Something isn't working

Comments

@MOshima-PIFSC
Copy link
Contributor

The github action for tests are failing due to a step that downloads SS3 executable. This can be re-worked and removed from the workflow and replaced with the r4ss::get_ss3_exe() function inside the test scripts.
@MOshima-PIFSC MOshima-PIFSC added the bug Something isn't working label Jan 17, 2024
@MOshima-PIFSC MOshima-PIFSC self-assigned this Jan 17, 2024
@MOshima-PIFSC MOshima-PIFSC linked a pull request Feb 2, 2024 that will close this issue
remove download ss from R-CMD-check.yml and download in testthat.R #98
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MOshima-PIFSC MOshima-PIFSC

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove download ss from R-CMD-check.yml and download in testthat.R PIFSCstockassessments/ss3diags
1 participant
@MOshima-PIFSC