Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use async streams instead of in-memory load when building image #86

Open
KSAlpha opened this issue Jan 20, 2019 · 0 comments
Open

Use async streams instead of in-memory load when building image #86

KSAlpha opened this issue Jan 20, 2019 · 0 comments
Labels
enhancement Improvements on performance or other factors
Milestone

Comments

@KSAlpha
Copy link
Member

KSAlpha commented Jan 20, 2019

#85 introduced docker API based image build using in-memory load of build context. This is not a robust behavior as a big build context may consume a lot of memory which can result in OOM exception.

Followings seem to be a good alternatives:

  • FramedRead
    Based on AsyncRead with blocking annotation, which requires Runtime running on thread pool. (Soma uses current_thread::Runtime)
  • futures-fs
    Starts additional thread pool.

Both requires 'non-current-thread` runtime (or thread pool) running, which is expected to be a big change from current implementations.

@KSAlpha KSAlpha added the enhancement Improvements on performance or other factors label Jan 20, 2019
@KSAlpha KSAlpha added this to the 0.1.0 milestone Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements on performance or other factors
Projects
None yet
Development

No branches or pull requests

1 participant