Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REV should adapt to aspect ratio of image #581

Open
jgostick opened this issue Aug 25, 2021 · 1 comment · May be fixed by #729
Open

REV should adapt to aspect ratio of image #581

jgostick opened this issue Aug 25, 2021 · 1 comment · May be fixed by #729

Comments

@jgostick
Copy link
Member

jgostick commented Aug 25, 2021

Some images are thin, like of fibrous media. In these cases the REV function will use cubes with a maximum size equal to the thin dimension. It might be handy to include a mode argument that controls this a bit. For instance, mode='equal' means cubes as we do now, mode='maximal' would mean cubes when smaller than min(im.shape), but uses cuboids when needed, and lastly mode='proportional' would mean the cube always has the same aspect ratio as the image. There would probably be other modes we could add in future....maybe spheres?

@jgostick
Copy link
Member Author

BTW, this relates to a discussion we had recently: #578

@ma-sadeghi ma-sadeghi changed the title rev should adapt to aspect ratio of image REV should adapt to aspect ratio of image Aug 25, 2021
@jgostick jgostick linked a pull request Sep 7, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant