Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename lr to learning_rate in create_model function #993

Open
DOMFIRMUS opened this issue Oct 15, 2024 · 0 comments
Open

Rename lr to learning_rate in create_model function #993

DOMFIRMUS opened this issue Oct 15, 2024 · 0 comments

Comments

@DOMFIRMUS
Copy link

The create_model function in the src/porespy/networks/_size_factors.py file currently uses lr as a parameter for learning rate, which can be unclear or inconsistent. For improved readability and consistency, we should rename the lr parameter to learning_rate.

Before

image

After

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DOMFIRMUS