Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"threading" placeholders with Celebration Event cards' subelements to avoid rebounce? #4

Open
POWERBACKme opened this issue Nov 3, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@POWERBACKme
Copy link
Owner

The Celebrations component contains a Vertical Timeline that maps the Celebration Event component.

Celebrations uses React Suspense with a Placeholder as a fallback.

If possible, it would be better to always render a parent component which contains placeholder elements "threaded" in with the real sub-elements that make up the Event component, instead of doing an either-or type render with the fallback placeholder or the fully rendered content.

This is because when the fallback changes to the rendered content, the Vertical Timeline has a "bounce-in" animation that is triggered a second time. A smoother effect would have this bounce only once on a parent element.

@POWERBACKme POWERBACKme added the enhancement New feature or request label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant