Fix issue where disableAutomaticSaving did not work when useParentNavigationBar was enabled. (#389)

radazzouz · web-flow · commit 33e2560517c1 · 2021-02-09T12:02:02.000-05:00
* Disable the `autosaveEnabled` configuration option when disabling autosave via the `disableAutomaticSaving` prop

* Bump version to 1.30.7
diff --git a/ios/RCTPSPDFKit/RCTPSPDFKitViewManager.m b/ios/RCTPSPDFKit/RCTPSPDFKitViewManager.m
@@ -98,7 +98,15 @@ @implementation RCTPSPDFKitViewManager
 
 RCT_EXPORT_VIEW_PROPERTY(disableDefaultActionForTappedAnnotations, BOOL)
 
-RCT_EXPORT_VIEW_PROPERTY(disableAutomaticSaving, BOOL)
+RCT_CUSTOM_VIEW_PROPERTY(disableAutomaticSaving, BOOL, RCTPSPDFKitView) {
+  if (json) {
+    view.disableAutomaticSaving = [RCTConvert BOOL:json];
+    [view.pdfController updateConfigurationWithBuilder:^(PSPDFConfigurationBuilder *builder) {
+      // Disable autosave in the configuration.
+      builder.autosaveEnabled = !view.disableAutomaticSaving;
+    }];
+  }
+}
 
 RCT_REMAP_VIEW_PROPERTY(color, tintColor, UIColor)
 
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-native-pspdfkit",
-  "version": "1.30.6",
+  "version": "1.30.7",
   "description": "A React Native module for the PSPDFKit library.",
   "keywords": [
     "react native",
diff --git a/samples/Catalog/package.json b/samples/Catalog/package.json
@@ -1,6 +1,6 @@
 {
   "name": "Catalog",
-  "version": "1.30.6",
+  "version": "1.30.7",
   "private": true,
   "scripts": {
     "start": "react-native start",
diff --git a/samples/NativeCatalog/package.json b/samples/NativeCatalog/package.json
@@ -1,6 +1,6 @@
 {
   "name": "NativeCatalog",
-  "version": "1.30.6",
+  "version": "1.30.7",
   "private": true,
   "scripts": {
     "android": "react-native run-android",

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "react-native-pspdfkit",`
`3`		`- "version": "1.30.6",`
	`3`	`+ "version": "1.30.7",`
`4`	`4`	`"description": "A React Native module for the PSPDFKit library.",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"react native",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "Catalog",`
`3`		`- "version": "1.30.6",`
	`3`	`+ "version": "1.30.7",`
`4`	`4`	`"private": true,`
`5`	`5`	`"scripts": {`
`6`	`6`	`"start": "react-native start",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "NativeCatalog",`
`3`		`- "version": "1.30.6",`
	`3`	`+ "version": "1.30.7",`
`4`	`4`	`"private": true,`
`5`	`5`	`"scripts": {`
`6`	`6`	`"android": "react-native run-android",`