-
-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Action: Streamline scripts in .github/workflows
#3079
Comments
Can i work on this? |
I can work on one of the PRs, if its possible to have 2 assignees. |
@palisadoes for the PR-1
|
|
@palisadoes can you see the previous comment and tell for PR-2 |
Leave the sensitive files unchanged |
Okay |
@palisadoes It looks like somone already did one script called app_health_check.sh for solving the repetition you showed in example. |
|
@palisadoes The shell script already there looks good and properly implemented, if I can change anything please let me know |
Therefore this should be closed as complete. |
Is your feature request related to a problem? Please describe.
.github/workflows
is starting to get clutteredDescribe the solution you'd like
This should require 2 PRs
PR 1
.github/workflows/scripts
directory.github/workflows
to this directory.github/workflows
to refer to this directoryPR 2
.github/workflows/pull-requests.yml
file has embedded scripts to test the start of the application. They are causing the file to get bloated. There is repetition in the tests..github/workflows/scripts
directory.github/workflows/scripts
directory. No YAML filesDescribe alternatives you've considered
Approach to be followed (optional)
Additional context
Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship
The text was updated successfully, but these errors were encountered: