Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figma: Tags Pages Violate The Figma Style Guide #3173

Open
palisadoes opened this issue Jan 6, 2025 · 1 comment
Open

Figma: Tags Pages Violate The Figma Style Guide #3173

palisadoes opened this issue Jan 6, 2025 · 1 comment
Assignees
Labels
bug Something isn't working feature request good first issue Good for newcomers ui/ux issue related and being worked with the figma file of the Admin UI

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Jan 6, 2025

Post a video of your work in the PR

Describe the bug

  1. Tags Pages Violate The Figma Style Guide

To Reproduce
Steps to reproduce the behavior:

  1. Style Related
    1. Login to the app
    2. Select an organization
    3. Select tags
    4. The figma guide is not followed fully

Expected behavior

  1. The screens shown must conform to Figma
  2. This must apply to the following were relevant:
    1. Users
    2. Admins
    3. SuperAdmins
  3. Tests must be written to ensure this does not happen again
  4. The CSS must be consolidated into this file using variables wherever possible
    1. src/style/app.module.css

Other

  1. We are migrating away from the green theme as part of our support for color blind users.
  2. Take cues from other similar elements in this file and the PR mentioned in the issue.
    1. https://www.figma.com/design/dmKt00m9GVSeA1nebnkxql/Untitled?node-id=0-1&node-type=canvas&t=TPzfh1DE9IxjzsEe-0
  3. Use a variable instead. There are appropriate blue/grey colors that have been used in other screens

Actual behavior

  • See screenshots

Screenshots
If applicable, add screenshots to help explain your problem.

  1. Screen
    image

Additional details

  1. Background color guide - Use these instead of those that may be different in sample pages below. Our Figma design is not consistent
    image
  2. Figma
    image
  3. Figma
    image

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@github-actions github-actions bot added bug Something isn't working ui/ux issue related and being worked with the figma file of the Admin UI unapproved good first issue Good for newcomers labels Jan 6, 2025
@bruno-keiko
Copy link

Can I work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature request good first issue Good for newcomers ui/ux issue related and being worked with the figma file of the Admin UI
Projects
Status: Backlog
Development

No branches or pull requests

2 participants