Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figma: Action Item Pages Violate The Figma Style Guide #3174

Open
palisadoes opened this issue Jan 6, 2025 · 7 comments
Open

Figma: Action Item Pages Violate The Figma Style Guide #3174

palisadoes opened this issue Jan 6, 2025 · 7 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers ui/ux issue related and being worked with the figma file of the Admin UI

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Jan 6, 2025

Post a video of your work in the PR

Describe the bug

  1. Action Item Pages Violate The Figma Style Guide

To Reproduce
Steps to reproduce the behavior:

  1. Style Related
    1. Login to the app
    2. Select an organization
    3. Select action items
    4. The figma guide is not followed fully

Expected behavior

  1. The screens shown must conform to Figma
  2. This must apply to the following were relevant:
    1. Users
    2. Admins
    3. SuperAdmins
  3. Tests must be written to ensure this does not happen again
  4. The CSS must be consolidated into this file using variables wherever possible
    1. src/style/app.module.css

Other

  1. The foundational work for this was completed in this PR:
  2. When in doubt about colors, take cues from other similar elements in this file and the PR mentioned in the issue.
    1. https://www.figma.com/design/dmKt00m9GVSeA1nebnkxql/Untitled?node-id=0-1&node-type=canvas&t=TPzfh1DE9IxjzsEe-0
  3. The desired single CSS file is:
    1. src/style/app.module.css
      1. Convert all code files to use this file.
      2. Delete all CSS files in this code path and below mentioned in the title. The src/style/app.module.css file must be the only source of CSS
  4. Use no CSS in:
    1. assets/css/app.css
  5. Use variable names that describe the function of the color and not the color itself. This will help with future attempts to having Dark Mode.
    1. For example --search-button-bg is much better than --light-blue
    2. NoMongo: Fix Stylesheet in Anticipation of Dark Mode #3296
  6. When refactoring modals, please refer to this PR that has created a standardized design patter for them.
    1. Updating to NEW COLOR SCHEME #2984
  7. Remove all references to HTML color codes in the files you edit except in src/style/app.module.css
  8. Buttons, and dropdowns must only have shadows when there is a mouse hover. Their color must not change
  9. Search boxes must only have shadows when selected

Actual behavior

  • See screenshots

Screenshots
If applicable, add screenshots to help explain your problem.

  1. Main Screen
    image
  2. Adding items
    image
  3. After adding items
    image

Additional details

There is no figma page for this. Take design cues from this page

  1. Background color guide - Use these instead of those that may be different in sample pages below. Our Figma design is not consistent
    image
  2. Manage action items
    image
  3. Guide
    image

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@palisadoes palisadoes added the bug Something isn't working label Jan 6, 2025
@github-actions github-actions bot added ui/ux issue related and being worked with the figma file of the Admin UI unapproved good first issue Good for newcomers labels Jan 6, 2025
@pranavnathe
Copy link
Contributor

I’d like to work on this issue. Could you please assign it to me?

@Shahmaz0
Copy link

I want to work on this issue, please assign it to me

@palisadoes
Copy link
Contributor Author

We created an this issue to do basic changes to the CSS colors for consistency

The resulting PR created a comprehensive design system for the entire app. This was unexpected. The approach was a long term goal that became immediately implementable. We had to act promptly.

We have just merged the PR. There will be a follow up PR to adjust some colors as the Figma design has lettering that is sometimes hard to read.

When this is done we'll need your assistance to merge the screens into the develop branch with this issue.

If your screens have not been affected, then you should use the new methodology to refactor them.

This is an extraordinary circumstance. I hope you will appreciate the decision.

@pranavnathe
Copy link
Contributor

Thanks for the update! I’ll check my screens and align them with the new method. I’ll assist with merging the screens into the develop branch when needed.

@palisadoes
Copy link
Contributor Author

Please proceed. The changes mentioned previously are mostly in components

@pranavnathe
Copy link
Contributor

Hi @palisadoes,
I have updated the CSS for this page (see attached video), but I wanted to confirm some details since the Figma designs for this page are not available. Currently, there are four models implemented: Create/Update Action Item, Action Item Details, Delete Action Item, and Action Item Status.

Could you please clarify in which modal the Edit and Delete buttons should be added — Action Item Details or Update Action Item? Additionally, should the modal titles be updated to align with the titles mentioned in the Figma design?

Looking forward to your guidance. Thank you!

Action.Items.mp4

@palisadoes
Copy link
Contributor Author

  1. Almost there. Make the following changes and submit a PR.
    1. We were getting so many different approaches to hovers, that we decided to use shadows for highlighting like Gmail. The direction below is different to the images posted in the first issue comment
      Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers ui/ux issue related and being worked with the figma file of the Admin UI
Projects
Status: Backlog
Development

No branches or pull requests

3 participants