-
-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figma: Action Item Pages Violate The Figma Style Guide #3174
Comments
I’d like to work on this issue. Could you please assign it to me? |
I want to work on this issue, please assign it to me |
We created an this issue to do basic changes to the CSS colors for consistency The resulting PR created a comprehensive design system for the entire app. This was unexpected. The approach was a long term goal that became immediately implementable. We had to act promptly. We have just merged the PR. There will be a follow up PR to adjust some colors as the Figma design has lettering that is sometimes hard to read. When this is done we'll need your assistance to merge the screens into the If your screens have not been affected, then you should use the new methodology to refactor them. This is an extraordinary circumstance. I hope you will appreciate the decision. |
Thanks for the update! I’ll check my screens and align them with the new method. I’ll assist with merging the screens into the develop branch when needed. |
Please proceed. The changes mentioned previously are mostly in components |
Hi @palisadoes, Could you please clarify in which modal the Edit and Delete buttons should be added — Action Item Details or Update Action Item? Additionally, should the modal titles be updated to align with the titles mentioned in the Figma design? Looking forward to your guidance. Thank you! Action.Items.mp4 |
Post a video of your work in the PR
Describe the bug
To Reproduce
Steps to reproduce the behavior:
Expected behavior
src/style/app.module.css
Other
src/style/app.module.css
src/style/app.module.css
file must be the only source of CSSassets/css/app.css
--search-button-bg
is much better than--light-blue
src/style/app.module.css
Actual behavior
Screenshots
If applicable, add screenshots to help explain your problem.
Additional details
There is no figma page for this. Take design cues from this page
Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship
The text was updated successfully, but these errors were encountered: