-
-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figma: Events Dashboard / Detail Screens Violate The Figma Style Guide #3182
Comments
I would like to work on this issue. Could you please assign it to me? |
We need someone to work on this who has had experience with the repo. There are many significant changes. |
@palisadoes I am working on issue #2880 shouldn't these css issue(replacing green with appropriate blue/grey) should come under the issue i am already working on? |
Thanks |
|
This needs to be fixed in the User Portal too. There is shared code. |
I want to work on this issue, please assign it to me |
Hey @Shahmaz0 I am already working on it please find another issue. |
Unassigning so you can work on the follow up for this: |
We created an this issue to do basic changes to the CSS colors for consistency The resulting PR created a comprehensive design system for the entire app. This was unexpected. The approach was a long term goal that became immediately implementable. We had to act promptly. We have just merged the PR. There will be a follow up PR to adjust some colors as the Figma design has lettering that is sometimes hard to read. When this is done we'll need your assistance to merge the screens into the If your screens have not been affected, then you should use the new methodology to refactor them. This is an extraordinary circumstance. I hope you will appreciate the decision. |
1 similar comment
We created an this issue to do basic changes to the CSS colors for consistency The resulting PR created a comprehensive design system for the entire app. This was unexpected. The approach was a long term goal that became immediately implementable. We had to act promptly. We have just merged the PR. There will be a follow up PR to adjust some colors as the Figma design has lettering that is sometimes hard to read. When this is done we'll need your assistance to merge the screens into the If your screens have not been affected, then you should use the new methodology to refactor them. This is an extraordinary circumstance. I hope you will appreciate the decision. |
@palisadoes Can I work on this issue? |
i would like to work on this .Could you please assign this issue to me @palisadoes @Cioppolo14 |
Hey, can you assign this to me, really want to work on this issue. |
Please proceed. The changes mentioned previously are mostly in components |
@palisadoes , I have attached the design changes that I have made. Please review these and suggest changes. Also Agendas and Statistics screens are not loading / empty. |
Post a video of your work in the PR
Describe the bug
To Reproduce
Steps to reproduce the behavior:
Expected behavior
src/style/app.module.css
Other
src/style/app.module.css
src/style/app.module.css
file must be the only source of CSSassets/css/app.css
--search-button-bg
is much better than--light-blue
src/style/app.module.css
Actual behavior
Screenshots
If applicable, add screenshots to help explain your problem.
Additional details
Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship
The text was updated successfully, but these errors were encountered: