Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Venue Update Fails Unless Name is Changed #3300

Closed
gkbishnoi07 opened this issue Jan 16, 2025 · 2 comments
Closed

Bug Report: Venue Update Fails Unless Name is Changed #3300

gkbishnoi07 opened this issue Jan 16, 2025 · 2 comments
Assignees
Labels
bug Something isn't working invalid This doesn't seem right unapproved

Comments

@gkbishnoi07
Copy link

Describe the bug

The venue update functionality fails unless the name of the venue is changed. Even if other fields (e.g., description, capacity, or venue image) are modified, the update is not reflected unless the venue name is altered.

To Reproduce

Steps to reproduce the behavior:

In talawa Admin portal
Go to the Venue Details modal.
Edit any field except for the venue name (e.g., description, capacity, or image).
Click the "Update Venue" button.
Observe that the venue does not update and throws an error.
Expected behavior
All changes, including description, capacity, or image, should be saved, regardless of whether the venue name is altered.

Actual behavior

The changes are not saved unless the venue name is modified. This results in an error message: "The submitted information is invalid. Please check your inputs and try again."

Screenshots

current bug (cannot update venue unless name change)

Screen.Recording.2025-01-17.021705.1.mp4

after solved bug(we can update any field)

Screen.Recording.2025-01-17.021831.mp4

Additional details
The issue seems to be caused by a conditional check in the code where updates are skipped if the venue name and other fields remain unchanged.
Refer to the file VenueModal.tsx .

@gkbishnoi07 gkbishnoi07 added the bug Something isn't working label Jan 16, 2025
@github-actions github-actions bot added invalid This doesn't seem right unapproved labels Jan 16, 2025
@gkbishnoi07
Copy link
Author

I have resolved this bug. Please assign it to me so I can create a pull request.

@gkbishnoi07 gkbishnoi07 changed the title Venue Update Fails Unless Name is Changed In Talawa Admin Bug Report: Venue Update Fails Unless Name is Changed In Talawa Admin Jan 16, 2025
@gkbishnoi07 gkbishnoi07 changed the title Bug Report: Venue Update Fails Unless Name is Changed In Talawa Admin Bug Report: Venue Update Fails Unless Name is Changed Jan 16, 2025
@gkbishnoi07
Copy link
Author

@palisadoes solved this bug can you assign to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right unapproved
Projects
None yet
Development

No branches or pull requests

2 participants