Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Drizzle Client in Codebase of develop-postgres branch #3210

Closed
sancheet230 opened this issue Feb 14, 2025 · 10 comments
Closed

Missing Drizzle Client in Codebase of develop-postgres branch #3210

sancheet230 opened this issue Feb 14, 2025 · 10 comments
Labels
bug Something isn't working unapproved Unapproved for Pull Request

Comments

@sancheet230
Copy link

sancheet230 commented Feb 14, 2025

Describe the bug
The codebase defines database schemas using Drizzle ORM, but it lacks a proper Drizzle client instance to interact with the database. This prevents the execution of queries, migrations, and other database operations.

To Reproduce
NA

Screenshots

Image

Additional details
This issue affects the ability to run migrations and database queries. A fix should be implemented to ensure seamless ORM functionality.

Proposed Fix
Implement a Drizzle client instance for PostgreSQL and update Documentation

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@sancheet230 sancheet230 added the bug Something isn't working label Feb 14, 2025
@github-actions github-actions bot added the unapproved Unapproved for Pull Request label Feb 14, 2025
@sancheet230
Copy link
Author

sancheet230 commented Feb 14, 2025

@palisadoes This needs to be fixed ASAP cause many queries will fail due to absence of DRIZZLE CLIENT my new test cases for PR #3176 is failing multiple times due to the same. I can work on this

@Piyushk8
Copy link

Isn't it defined already inside the Graphql context ? might as well explain in detail as if it was not defined queries working in Api wouldn't work as expected right ?

@sancheet230
Copy link
Author

sancheet230 commented Feb 14, 2025

@Piyushk8 i checked codebase it's not defined and if it's not defined than all drizzle orm queries will fail and drizzle migrations required a database connection which will fail as well and backend depends on database queries due to which API's will break due to failed requests

@palisadoes
Copy link
Contributor

@xoldd PTAL

@PurnenduMIshra129th
Copy link

@palisadoes @sancheet230 please assign.

@dhanagopu
Copy link

@PurnenduMIshra129th Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

@sancheet230
Copy link
Author

@palisadoes please assign sir

@bandhan-majumder
Copy link

It's already working fine. It interacts with the database properly.

@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Feb 15, 2025
@palisadoes palisadoes reopened this Feb 15, 2025
@sancheet230
Copy link
Author

@palisadoes Should I keep this issue open

@palisadoes
Copy link
Contributor

Closing. There aren't reports of this failing.

@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unapproved Unapproved for Pull Request
Projects
None yet
Development

No branches or pull requests

6 participants