Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SEFFInterpretationContext #76

Open
stiesssh opened this issue May 15, 2024 · 0 comments
Open

Refactor SEFFInterpretationContext #76

stiesssh opened this issue May 15, 2024 · 0 comments

Comments

@stiesssh
Copy link
Collaborator

stiesssh commented May 15, 2024

The SEFFInterpretationContext has some inconsistencies and questionable design decisions, e.g.:

  • Children have the same calledFrom attribute as their parents. However, i think a SEFFIC that has a parent (i.e. was not called) should not have a caller. If at any point, a child must know whether it was called, or by whom it was called, the query should be passed to the parent.
  • Children have the same calledFrom attribute as their parents, but not their callOverWireRequest attribute. However i think, those two attributes should always appear together, i.e. either both are set or both are unset.
  • Regarding the CallOverWireRequest, most information in there are redundant, and when progressing with the SEFF interpretation, we rely mostly on the GeneralEntryRequest anyway. Can we get rid of the CallOverWireRequest or at least slim it down?

Goal of this issue is to discusse the point above and fix them if reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant