You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was checking your CSS and among other issues with general style rules (anchor tags using their inherent inline style to create a line separator, flex not actually being used as flex, button hover background color styles not providing contrast against the page background) I found that the stylesheets themselves were seemingly not formatted.
Since you have more than 20 lines (arbitrary) of CSS, you should probably look into just adding something like Prettier or Biome.
I also noticed you cited ChatGPT but the code does not seem to be cited anywhere within the code base This might be part of the reason for these changes, though I haven't comprehensively checked the commit log (It is 4 am).
Oh and some UX freebies:
App.css 53 Don't have right padding, consider making them block level and then using the gap property. Also you don't really need the :link unless you're styling anchor tags used incorrectly (as buttons for JS) separately. If you are... uhh don't? It makes screenreaders a bit unhappy with you
App.css 513 Change this to just overflow-x. That will fix the horizontal scrollbar.
Make images display: block. That's where your mystery 4px bottom margin is if you're ever wondering. If you really need inline images, add that separately. You probably don't need inline images
yeah.
The text was updated successfully, but these errors were encountered:
I was checking your CSS and among other issues with general style rules (anchor tags using their inherent inline style to create a line separator, flex not actually being used as flex, button hover background color styles not providing contrast against the page background) I found that the stylesheets themselves were seemingly not formatted.
Some examples:
Since you have more than 20 lines (arbitrary) of CSS, you should probably look into just adding something like Prettier or Biome.
I also noticed you cited ChatGPT but the code does not seem to be cited anywhere within the code base This might be part of the reason for these changes, though I haven't comprehensively checked the commit log (It is 4 am).
Oh and some UX freebies:
gap
property. Also you don't really need the:link
unless you're styling anchor tags used incorrectly (as buttons for JS) separately. If you are... uhh don't? It makes screenreaders a bit unhappy with youdisplay: block
. That's where your mystery 4px bottom margin is if you're ever wondering. If you really need inline images, add that separately. You probably don't need inline imagesyeah.
The text was updated successfully, but these errors were encountered: