Fix accidental write in pcap #257
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #257 +/- ##
=======================================
Coverage 69.42% 69.42%
=======================================
Files 20 20
Lines 1207 1207
=======================================
Hits 838 838
Misses 369 369 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Merged in #258 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After doing some simulations with my new test target, I found the following situation right at the start:
An unsolicited write burst is done to location 0, which I believe is addressing the On Chip Memory (and probably not catastrophic). The problem is that aw_throttle and w_throttle are initialized to 0 (which is the value it takes when dma_start is signaled), however, I took this as an opportunity to simplify the code(instead of changing the initial value) and got rid of those 2 signals and also improved the code style.
This bug was not introduced in 3a1b545, because uninitialized signals are implicitly set to 0, this bug has been there forever but because the write was not catastrophic, we never noticed.