Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ePapirus] KDE Connect Indicator icon in elementary os #1245

Closed
rituraj22 opened this issue May 1, 2018 · 19 comments
Closed

[ePapirus] KDE Connect Indicator icon in elementary os #1245

rituraj22 opened this issue May 1, 2018 · 19 comments

Comments

@rituraj22
Copy link

rituraj22 commented May 1, 2018

The icon for kde connect in ePapirus is not monochrome.

I am using elementary 0.4.1 Loki with kdeconnect from https://launchpad.net/~webupd8team/+archive/ubuntu/indicator-kdeconnect (0.9.4-1~webupd8~xenial0)
with papirus icon theme from official ppa (build 20180429-2352+pkg18~ubuntu16.04.1)

screenshot from 2018-05-01 11 57 24

@varlesh
Copy link
Contributor

varlesh commented May 1, 2018

try update icon cache:
sudo gtk-update-icon-cache -f /usr/share/icons/ePapirus

@rituraj22
Copy link
Author

I tried it. But it won't update. I tried to change icon packs, and the icon does change for other icon packs, but for some reason, ePapirus still has this icon.

I even rebooted my system, but it still shows same icon.

@varlesh
Copy link
Contributor

varlesh commented May 1, 2018

hm, it's strange and i'm not understand why used 32px icon. 24px available:
https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/blob/master/ePapirus/24x24/panel/smartphoneconnected.svg

@varlesh
Copy link
Contributor

varlesh commented May 1, 2018

This 32px colorized icons used for notifications and kde konnect settings window:
image

@varlesh
Copy link
Contributor

varlesh commented May 1, 2018

@SmartFinn hi, have ideas?

[24x24/panel]
Context=Status
Size=24
Type=Fixed
[32x32/status]
Context=Status
Size=32
Type=Fixed

@rituraj22
Copy link
Author

Well I looked into it and found out that the icon pack with name smartphone-connected.svg works but in ePapirus it is smartphoneconnected.svg

@varlesh
Copy link
Contributor

varlesh commented May 1, 2018

@rituraj22 nope, it's old icon names. Icons renamed by KDE dev upstream and kde-connect indicator too:
KDE/kdeconnect-kde@e72bbfe#diff-50c4d86debe5015d6def16889e9a0814
b4j4/indicator-kdeconnect@ab39a75#diff-08be054e69b58bd2f6a30f979de16c6e

@varlesh
Copy link
Contributor

varlesh commented May 1, 2018

@rituraj22 also see release notes:
https://github.com/Bajoja/indicator-kdeconnect/releases/tag/0.9.4

Add Languages: Greek, Hebrew, Simplified Chinese
Fix Icons Name

@rituraj22
Copy link
Author

For the time being, I made a copy of the icon with name smartphone-connected.svg , and it's working fine. Thanks for the help. Hope you guys will sort out the issue.

@varlesh
Copy link
Contributor

varlesh commented May 1, 2018

maybe you use old package indicator-kdeconnect/kdeconnect?

@rituraj22
Copy link
Author

rituraj22 commented May 1, 2018

I have uninstalled kdeconnect and indicator-kdeconnect. Redownloaded, and installed.
So now when i run update, it shows

indicator-kdeconnect is already the newest version (0.9.4-1~webupd8~xenial0).
kdeconnect is already the newest version (1.0.3-0ubuntu2~webupd8~xenial1).

Still, the names work like in older versions. So I don't know what's wrong with it.

@varlesh
Copy link
Contributor

varlesh commented May 1, 2018

you use old version kdeconnect, fresh version 1.3:
https://cgit.kde.org/kdeconnect-kde.git

@varlesh
Copy link
Contributor

varlesh commented May 1, 2018

fresh version available on Neon PPA:
https://archive.neon.kde.org/user/pool/main/k/kdeconnect/
But i don't know it's compability with eOS or not, need check this

@rituraj22
Copy link
Author

@varlesh There are some issues with dependancies in that version

@varlesh
Copy link
Contributor

varlesh commented May 1, 2018

i set upstream bug, because i think it's happened with old package kdeconnect.
issues openned on upstream PPA:
b4j4/indicator-kdeconnect#126

@malysps
Copy link

malysps commented Jun 5, 2018

I had the same issue on my system with Papirus-Adapta. I solved it by creating symlinks.

@varlesh Any reason against creating symlinks with added "-" to smartphoneconnected.svg, smartphonedisconnected.svg and smartphonetrusted.svg in all Papirus icon sets? Seems like an easy solution for this issue.

@varlesh
Copy link
Contributor

varlesh commented Jun 5, 2018

It's not our problem. KDEConnect and Indicator KDEConnect already released with new icon names:
https://github.com/Bajoja/indicator-kdeconnect/releases/tag/0.9.4
https://cgit.kde.org/kdeconnect-kde.git/tree/icon
Please report bug to WEBUPD8 Team - they used old version kdeconnect on PPA:
https://launchpad.net/~webupd8team/+archive/ubuntu/indicator-kdeconnect
Or build kdeconnect for your self

@varlesh
Copy link
Contributor

varlesh commented Jun 5, 2018

I'm soon add symlinks, because fresh kdeconnect version impossible used on Xenial, depends for build failed:

set(QT_MIN_VERSION "5.7.0")
set(KF5_MIN_VERSION "5.42.0")

But on Xenial used KF5 5.18:
https://packages.ubuntu.com/search?suite=xenial&section=all&arch=any&keywords=libkf5&searchon=names

@varlesh
Copy link
Contributor

varlesh commented Jun 5, 2018

@malysps @rituraj22 symlinks added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants