fix(core): handle setting falsy value in proxy providers (#118)

* fix(proxy-provider-manager): handle setting falsy value

Co-authored-by: Jerry Laloan <jerrylaloan@users.noreply.github.com>

Author: alexandre-abrioux

packages/core/src/lib/proxy-provider/proxy-provider-manager.ts

@@ -108,7 +108,7 @@ export class ProxyProviderManager {
                 return getProvider()[prop];
             },
             set(_, prop, value) {
-                return (getProvider()[prop] = value);
+                return Reflect.set(getProvider(), prop, value);
             },
             ownKeys() {
                 return Reflect.ownKeys(getProvider());

packages/core/test/proxy-providers/proxy-providers.spec.ts

@@ -18,6 +18,8 @@ import {
     ProxyResult,
     ProxyResults,
 } from './expect-ids-proxy';
+import { globalClsService } from '../../src/lib/cls-service.globals';
+import { ProxyProviderManager } from '../../src/lib/proxy-provider';
 
 @Injectable()
 class InjectedClass {
@@ -142,3 +144,24 @@ describe('Proxy providers', () => {
         await expectOkIdsProxy(app);
     });
 });
+
+describe('Edge cases', () => {
+    it('proxy should allow setting falsy value', async () => {
+        const clsService = globalClsService;
+        const symbol = Symbol('testSymbol');
+        const proxyProvider = ProxyProviderManager.createProxyProvider({
+            provide: symbol,
+            type: 'object',
+            useFactory: () => ({
+                booleanTest: true,
+            }),
+        });
+        const proxy = proxyProvider.useFactory();
+        await clsService.run(async () => {
+            await ProxyProviderManager.resolveProxyProviders();
+            expect(proxy.booleanTest).toBe(true);
+            proxy.booleanTest = false;
+            expect(proxy.booleanTest).toBe(false);
+        });
+    });
+});