chore(release): Test and deploy to Production v8.21.1 (#10721)

Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Matt Krick <matt.krick@gmail.com>
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
Co-authored-by: Georg Bremer <github@dschoordsch.de>
Co-authored-by: Bruce Tian <tianrunhe@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nick O'Ferrall <nickoferrall@gmail.com>
Co-authored-by: Rafa <101704572+rafaelromcar-parabol@users.noreply.github.com>
Co-authored-by: Dale Bumblis <135627447+dbumblis-parabol@users.noreply.github.com>
Co-authored-by: Terry Acker <ackernaut@gmail.com>
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Sven Seeberg <sven@geeq.de>
Co-authored-by: Smruti Ranjan Badatya <35039502+iamsmruti@users.noreply.github.com>
Co-authored-by: Jordan Husney <jordan.husney@gmail.com>
Co-authored-by: github-actions <github-actions@github.com>

Author: 16 people

.env.example

@@ -42,6 +42,7 @@ AI_EMBEDDER_WORKERS='1'
 # AWS_ACCESS_KEY_ID='key_AWS_ACCESS_KEY_ID'
 # AWS_REGION='key_AWS_REGION'
 # AWS_SECRET_ACCESS_KEY='key_AWS_SECRET_ACCESS_KEY'
+# AWS_S3_BUCKET='key_AWS_BUCKET'
 
 # MONITORING
 # SENTRY_DSN='key_SENTRY_DSN'

.release-please-manifest.json

@@ -1,3 +1,3 @@
 {
-  ".": "8.21.0"
+  ".": "8.21.1"
 }

CHANGELOG.md

@@ -5,6 +5,20 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 This CHANGELOG follows conventions [outlined here](http://keepachangelog.com/).
 
+## [8.21.1](https://github.com/ParabolInc/parabol/compare/v8.21.0...v8.21.1) (2025-01-22)
+
+
+### Fixed
+
+* React error on forgot password page ([#10717](https://github.com/ParabolInc/parabol/issues/10717)) ([8c8d600](https://github.com/ParabolInc/parabol/commit/8c8d6003a6e5e65674784f6f41897ab886c540b0))
+* S3 bucket name used from the application configuration instead of infered from CDN_URL ([#10661](https://github.com/ParabolInc/parabol/issues/10661)) ([7f3051d](https://github.com/ParabolInc/parabol/commit/7f3051d6d82c44982d31d296875f834e2cad5a95))
+* Tab button style ([#10715](https://github.com/ParabolInc/parabol/issues/10715)) ([216eb40](https://github.com/ParabolInc/parabol/commit/216eb40d8baa062a708275aebe933d921b2d3f27))
+
+
+### Changed
+
+* Add AWS_S3_BUCKET to .env.example ([#10718](https://github.com/ParabolInc/parabol/issues/10718)) ([001cf41](https://github.com/ParabolInc/parabol/commit/001cf41eed554c97c0d719b898258f83643bc2e7))
+
 ## [8.21.0](https://github.com/ParabolInc/parabol/compare/v8.20.1...v8.21.0) (2025-01-21)
 
 

package.json

@@ -3,7 +3,7 @@
   "description": "An open-source app for building smarter, more agile teams.",
   "author": "Parabol Inc. <love@parabol.co> (http://github.com/ParabolInc)",
   "license": "AGPL-3.0",
-  "version": "8.21.0",
+  "version": "8.21.1",
   "repository": {
     "type": "git",
     "url": "https://github.com/ParabolInc/parabol"

packages/chronos/package.json

@@ -1,6 +1,6 @@
 {
   "name": "chronos",
-  "version": "8.21.0",
+  "version": "8.21.1",
   "description": "A cron job scheduler",
   "author": "Matt Krick <matt.krick@gmail.com>",
   "homepage": "https://github.com/ParabolInc/parabol/tree/master/packages/chronos#readme",
@@ -25,6 +25,6 @@
   },
   "dependencies": {
     "cron": "^2.3.1",
-    "parabol-server": "8.21.0"
+    "parabol-server": "8.21.1"
   }
 }

packages/client/components/GenericAuthentication.tsx

@@ -78,6 +78,16 @@ const GenericAuthentication = (props: Props) => {
   const isMicrosoftAuthEnabled = window.__ACTION__.AUTH_MICROSOFT_ENABLED
   const isInternalAuthEnabled = window.__ACTION__.AUTH_INTERNAL_ENABLED
   const isSSOAuthEnabled = window.__ACTION__.AUTH_SSO_ENABLED
+
+  const isCreate = page === 'create-account'
+  const action = isCreate ? CREATE_ACCOUNT_LABEL : SIGNIN_LABEL
+  const pageTitle = `${action} | Parabol`
+  const metaCopy = isCreate
+    ? 'Give structure to your meetings to get your team talking and moving forward faster. Get started in 44 seconds or less.'
+    : 'Access Parabol to streamline your agile meetings. Collaborate, reflect, and grow with your team in real-time.'
+  useDocumentTitle(pageTitle, action)
+  useMetaTagContent(metaCopy)
+
   if (page === 'forgot-password') {
     return <ForgotPasswordPage goToPage={goToPage} />
   }
@@ -89,17 +99,9 @@ const GenericAuthentication = (props: Props) => {
     }
   }
 
-  const isCreate = page === 'create-account'
-  const action = isCreate ? CREATE_ACCOUNT_LABEL : SIGNIN_LABEL
   const counterAction = isCreate ? SIGNIN_LABEL : CREATE_ACCOUNT_LABEL
   const counterActionSlug = isCreate ? SIGNIN_SLUG : CREATE_ACCOUNT_SLUG
   const actionCopy = isCreate ? 'Already have an account? ' : 'New to Parabol? '
-  const pageTitle = `${action} | Parabol`
-  const metaCopy = isCreate
-    ? 'Give structure to your meetings to get your team talking and moving forward faster. Get started in 44 seconds or less.'
-    : 'Access Parabol to streamline your agile meetings. Collaborate, reflect, and grow with your team in real-time.'
-  useDocumentTitle(pageTitle, action)
-  useMetaTagContent(metaCopy)
   const title = teamName ? `${teamName} is waiting` : action
   const onForgot = () => {
     goToPage('forgot-password', `?email=${emailRef.current?.email()}`)

packages/client/components/InvitationLinkDialog.tsx

@@ -42,16 +42,20 @@ const InvitationLinkDialog = (props: Props) => {
     return <TeamInvitationErrorNotFound isMassInvite />
   }
   const {errorType, teamName} = massInvitation
+  const pageTitle = teamName ? `${teamName} | Parabol` : 'Join | Parabol'
+  const pageName = teamName ? `Join ${teamName}` : 'Join Parabol'
+  const metaCopy = teamName
+    ? `Join ${teamName} on Parabol, the essential tool for making meetings efficient or replacing them with structured, asynchronous collaboration.`
+    : `Join Parabol, the essential tool for making meetings efficient or replacing them with structured, asynchronous collaboration.`
+  useDocumentTitle(pageTitle, pageName)
+  useMetaTagContent(metaCopy)
+
   switch (errorType) {
     case 'notFound':
       return <TeamInvitationErrorNotFound isMassInvite />
     case 'expired':
       return <InvitationLinkErrorExpired massInvitation={massInvitation} />
   }
-  useDocumentTitle(`${teamName} | Parabol`, `Join ${teamName}`)
-  useMetaTagContent(
-    `Join ${teamName} on Parabol,the essential tool for making meetings efficient or replacing them with structured, asynchronous collaboration.`
-  )
   const {authToken} = atmosphere
   if (authToken) {
     return <TeamInvitationAccept invitationToken={token} />

packages/client/components/Tab/Tab.tsx

@@ -13,8 +13,8 @@ const Tab = forwardRef((props: Props, ref: Ref<HTMLButtonElement>) => {
   return (
     <button
       className={cn(
-        'flex cursor-default select-none appearance-none items-center justify-center border-0 px-4 py-3 text-sm leading-5 text-grape-600 outline-0',
-        isActive ? 'text-grape-700' : 'cursor-pointer',
+        'flex cursor-default select-none appearance-none items-center justify-center border-0 bg-inherit px-4 py-3 text-sm leading-5 outline-0',
+        isActive ? 'text-grape-700' : 'cursor-pointer text-slate-600',
         className
       )}
       onClick={onClick}

packages/client/package.json

@@ -3,7 +3,7 @@
   "description": "An open-source app for building smarter, more agile teams.",
   "author": "Parabol Inc. <love@parabol.co> (http://github.com/ParabolInc)",
   "license": "AGPL-3.0",
-  "version": "8.21.0",
+  "version": "8.21.1",
   "repository": {
     "type": "git",
     "url": "https://github.com/ParabolInc/parabol"

packages/client/tailwindTheme.ts

@@ -7,6 +7,7 @@ export default {
   theme: {
     colors: {
       transparent: 'transparent',
+      inherit: 'inherit',
       current: 'currentColor',
       black: defaultColors.black,
       white: defaultColors.white,

packages/embedder/package.json

@@ -1,6 +1,6 @@
 {
   "name": "parabol-embedder",
-  "version": "8.21.0",
+  "version": "8.21.1",
   "description": "A service that computes embedding vectors from Parabol objects",
   "author": "Jordan Husney <jordan.husney@gmail.com>",
   "homepage": "https://github.com/ParabolInc/parabol/tree/master/packages/embedder#readme",

packages/gql-executor/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gql-executor",
-  "version": "8.21.0",
+  "version": "8.21.1",
   "description": "A Stateless GraphQL Executor",
   "author": "Matt Krick <matt.krick@gmail.com>",
   "homepage": "https://github.com/ParabolInc/parabol/tree/master/packages/gqlExecutor#readme",
@@ -25,8 +25,8 @@
   },
   "dependencies": {
     "dd-trace": "^5.0.0",
-    "parabol-client": "8.21.0",
-    "parabol-server": "8.21.0",
+    "parabol-client": "8.21.1",
+    "parabol-server": "8.21.1",
     "undici": "^5.26.2"
   }
 }

packages/integration-tests/package.json

@@ -2,7 +2,7 @@
   "name": "integration-tests",
   "author": "Parabol Inc. <love@parabol.co> (http://github.com/ParabolInc)",
   "license": "AGPL-3.0",
-  "version": "8.21.0",
+  "version": "8.21.1",
   "description": "",
   "main": "index.js",
   "scripts": {

packages/mattermost-plugin/package.json

@@ -1,6 +1,6 @@
 {
   "name": "parabol-mattermost-plugin",
-  "version": "8.21.0",
+  "version": "8.21.1",
   "description": "A service that computes embedding vectors from Parabol objects",
   "author": "Georg Bremer <github@dschoordsch.de>",
   "homepage": "https://github.com/ParabolInc/parabol/tree/master/packages/mattermost-plugin#readme",
@@ -48,7 +48,7 @@
     "ts-node-dev": "^1.0.0-pre.44"
   },
   "dependencies": {
-    "parabol-client": "8.21.0",
+    "parabol-client": "8.21.1",
     "@mattermost/compass-icons": "0.1.47",
     "@reduxjs/toolkit": "1.9.7",
     "@tiptap/core": "^2.9.1",

packages/server/fileStorage/S3FileStoreManager.ts

@@ -32,12 +32,16 @@ export default class S3Manager extends FileStoreManager {
   // e.g. development, production
   private envSubDir: string
 
+  // e.g. action-files.parabol.co
+  private bucket: string
+
   // e.g. https://action-files.parabol.co
   baseUrl: string
   private s3: S3Client
   constructor() {
     super()
-    const {CDN_BASE_URL, AWS_REGION, AWS_SECRET_ACCESS_KEY, AWS_ACCESS_KEY_ID} = process.env
+    const {CDN_BASE_URL, AWS_REGION, AWS_SECRET_ACCESS_KEY, AWS_ACCESS_KEY_ID, AWS_S3_BUCKET} =
+      process.env
     if (!CDN_BASE_URL || CDN_BASE_URL === 'key_CDN_BASE_URL') {
       throw new Error('CDN_BASE_URL ENV VAR NOT SET')
     }
@@ -50,18 +54,24 @@ export default class S3Manager extends FileStoreManager {
     if (pathname.endsWith('/'))
       throw new Error('CDN_BASE_URL must end with the env, no trailing slash, e.g. /production')
 
+    if (!AWS_S3_BUCKET) {
+      throw new Error('AWS_S3_BUCKET required when using AWS S3 as filestore provider')
+    }
+
     this.envSubDir = pathname.split('/').at(-1) as string
 
     this.baseUrl = baseUrl.href.slice(0, baseUrl.href.lastIndexOf(this.envSubDir))
+    this.bucket = AWS_S3_BUCKET
+
     // credentials are optional since the file store could be public & not need a key to write
     const credentials =
       AWS_ACCESS_KEY_ID && AWS_SECRET_ACCESS_KEY
         ? {accessKeyId: AWS_ACCESS_KEY_ID, secretAccessKey: AWS_SECRET_ACCESS_KEY}
         : undefined
     this.s3 = new S3Client({
       credentials,
-      // The bucket is inferred from the CDN_BASE_URL
-      bucketEndpoint: true,
+      // Using true fails to work on the checkExist method, it returns a 403
+      bucketEndpoint: false,
       region: AWS_REGION,
       followRegionRedirects: true,
       retryStrategy: new CloudflareRetry(3)
@@ -75,7 +85,7 @@ export default class S3Manager extends FileStoreManager {
   protected async putFile(file: ArrayBufferLike, fullPath: string) {
     const s3Params = {
       Body: Buffer.from(file),
-      Bucket: this.baseUrl,
+      Bucket: this.bucket,
       Key: fullPath,
       ContentType: mime.lookup(fullPath) || 'application/octet-stream'
     }
@@ -98,17 +108,18 @@ export default class S3Manager extends FileStoreManager {
   async checkExists(key: string, assetDir?: FileAssetDir) {
     const Key = this.prependPath(key, assetDir)
     try {
-      await this.s3.send(new HeadObjectCommand({Bucket: this.baseUrl, Key}))
+      await this.s3.send(new HeadObjectCommand({Bucket: this.bucket, Key}))
     } catch (e) {
       if (e instanceof Error && e.name === 'NotFound') return false
+      Logger.log(`Invalid error ${(e as Error).name}`)
     }
     return true
   }
 
   async presignUrl(url: string) {
     // Important to decodeURI so `getSignedUrl` doesn't double encode e.g. local|123/avatars/123.jpg
     const key = decodeURI(url.slice(this.baseUrl.length))
-    const command = new GetObjectCommand({Bucket: this.baseUrl, Key: key})
+    const command = new GetObjectCommand({Bucket: this.bucket, Key: key})
     const encodedUri = await getSignedUrl(this.s3, command, {expiresIn: 604800})
     return encodedUri
   }

packages/server/package.json

@@ -3,7 +3,7 @@
   "description": "An open-source app for building smarter, more agile teams.",
   "author": "Parabol Inc. <love@parabol.co> (http://github.com/ParabolInc)",
   "license": "AGPL-3.0",
-  "version": "8.21.0",
+  "version": "8.21.1",
   "repository": {
     "type": "git",
     "url": "https://github.com/ParabolInc/parabol"
@@ -126,7 +126,7 @@
     "oauth-1.0a": "^2.2.6",
     "openai": "^4.53.0",
     "oy-vey": "^0.12.1",
-    "parabol-client": "8.21.0",
+    "parabol-client": "8.21.1",
     "pg": "^8.5.1",
     "react": "^17.0.2",
     "react-dom": "^17.0.2",

scripts/toolboxSrc/pushToCDN.ts

@@ -1,8 +1,8 @@
 import fs from 'fs'
 import getFileStoreManager from 'parabol-server/fileStorage/getFileStoreManager'
+import {Logger} from 'parabol-server/utils/Logger'
 import path from 'path'
 import getProjectRoot from '../webpack/utils/getProjectRoot'
-import {Logger} from 'parabol-server/utils/Logger'
 
 const PROJECT_ROOT = getProjectRoot()
 
@@ -66,7 +66,7 @@ const pushServerAssetsToCDN = async () => {
     // static assets in /dist/images are already hosted at /static/images
     if (process.env.FILE_STORE_PROVIDER === 'local') return
     const targetObject = `images/${filename}`
-    const exists = await fileStoreManager.checkExists(targetObject)
+    const exists = await fileStoreManager.checkExists(targetObject, 'build')
     if (exists) return false
     const buffer = await fs.promises.readFile(path.join(localServerAssetsDir, filename))
     const url = await fileStoreManager.putBuildFile(buffer, targetObject)