Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value of coarse_res and upsample_res for ScanNet #29

Open
justachetan opened this issue Apr 10, 2024 · 3 comments
Open

Value of coarse_res and upsample_res for ScanNet #29

justachetan opened this issue Apr 10, 2024 · 3 comments

Comments

@justachetan
Copy link

Hi @Parskatt ,

I am trying to run an evaluation of roma_indoor on ScanNet, like what you have used for roma_outdoor in RoMa/experiments/eval_roma_outdoor.py. Could you please tell me what values of coarse_res and upsample_res to use with ScanNet when initializing the model?

Thanks!

Regards,
Aditya

@Parskatt
Copy link
Owner

Hi, I think I used the default values as in roma_indoor. Although it could be the case that I didn't use upsample_preds, I don't quite remember.

@justachetan
Copy link
Author

Thanks! It seems the code does use upsample_preds:

def roma_indoor(device, weights=None, dinov2_weights=None, coarse_res: Union[int,tuple[int,int]] = 560, upsample_res: Union[int,tuple[int,int]] = 864, amp_dtype: torch.dtype = torch.float16):

Would it be possible to get the parameters used to generate the results? I am getting quite poor results for keypoint matching on the ScanNet test case

@Parskatt
Copy link
Owner

If you run the model (without keypoints), are you able to get results comparable to our reported results?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants