From f5d7f044259781942f95f4acf3b1a485b8ef1468 Mon Sep 17 00:00:00 2001 From: Jannik-Hm Date: Fri, 21 Nov 2025 09:07:16 +0100 Subject: [PATCH 1/2] added error message for unknown primitive type --- main.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/main.go b/main.go index f129876..313a9be 100644 --- a/main.go +++ b/main.go @@ -48,7 +48,10 @@ func GetModel(conf ModelReaderConf, desiredSize MeshTypes.Vector) (*MeshTypes.Me default: return nil, fmt.Errorf("unknown model type %s", filetype) } - } else if conf.PrimitiveType != "Undefined" && Primitives.Primitives[conf.PrimitiveType] != nil { + } else if conf.PrimitiveType != "Undefined" { + if Primitives.Primitives[conf.PrimitiveType] == nil { + return nil, fmt.Errorf("unknown primitive type %s", conf.PrimitiveType) + } tempMesh := Primitives.Primitives[conf.PrimitiveType].Copy() mesh = &tempMesh mesh.ScaleToDimensions(&desiredSize) From 3b491b3016bd8a0649fd75bead6675f11675e69c Mon Sep 17 00:00:00 2001 From: Jannik-Hm Date: Fri, 21 Nov 2025 09:10:54 +0100 Subject: [PATCH 2/2] added error for invalid ModelReader conf --- main.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/main.go b/main.go index 313a9be..c658bdf 100644 --- a/main.go +++ b/main.go @@ -55,6 +55,8 @@ func GetModel(conf ModelReaderConf, desiredSize MeshTypes.Vector) (*MeshTypes.Me tempMesh := Primitives.Primitives[conf.PrimitiveType].Copy() mesh = &tempMesh mesh.ScaleToDimensions(&desiredSize) + } else { + return nil, fmt.Errorf("invalid ModelReader config") } return mesh, nil