Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An Option Page for configuration variable could be very useful #196

Open
vtasio opened this issue Feb 3, 2021 · 6 comments
Open

An Option Page for configuration variable could be very useful #196

vtasio opened this issue Feb 3, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@vtasio
Copy link
Contributor

vtasio commented Feb 3, 2021

A page that configuration such as the below could be saved/changed and used:

  • Scan Engine Max retries
  • Number of second to wait before perform a request to scan engine
  • In how many items to split the assets during scan
  • Haw many concurrent jobs to start
  • etc...
@MaKyOtOx
Copy link
Contributor

MaKyOtOx commented Feb 3, 2021

hi @vtasio : great idea. We could also use the Settings model for global configuration parameters ?

@MaKyOtOx MaKyOtOx self-assigned this Feb 3, 2021
@MaKyOtOx MaKyOtOx added the enhancement New feature or request label Feb 3, 2021
@vtasio
Copy link
Contributor Author

vtasio commented Feb 3, 2021

To tell you the truth , i have not used that menu at all. But i think i got it . You can use in setting all the variable that can be found in https://github.com/Patrowl/PatrowlDocs/blob/master/installation/patrowlmanager-settings.md and override the one's in the config files ?

Probably not all , i think you are only using it for the "Alert notification settings" on the above link ?

@MaKyOtOx
Copy link
Contributor

MaKyOtOx commented Feb 3, 2021

Yes, it would be nice. We just have to clearly specify a priority order. Example:
Scan Settings > Engine Settings > Global Settings > Environment variables

@MaKyOtOx
Copy link
Contributor

MaKyOtOx commented Feb 3, 2021

Yes, I'm just using the Settings model for notification settings. BTW, it could be extended to all global variables ?

@vtasio
Copy link
Contributor Author

vtasio commented Feb 3, 2021

I will try to find a way to make but, this might be a little more complicated for my knowledge. If you start with something that i can rely on (before me ), i believe i could extend it .

@vtasio
Copy link
Contributor Author

vtasio commented Feb 4, 2021

Question: are you setting up somewhere the number of Jobs to it is the outcome of asset split during scan ? for example 400 assets scan , splited by 100 . This will produce 4 concurrent jobs ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants