Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datasets.py standardization #8

Open
PavlosMelissinos opened this issue May 19, 2017 · 1 comment
Open

datasets.py standardization #8

PavlosMelissinos opened this issue May 19, 2017 · 1 comment

Comments

@PavlosMelissinos
Copy link
Owner

  1. Better couple properties of the dataset together. Conversions between IDS <-> CIDS <-> CATEGORIES <-> PALETTE should be done in a different way.

  2. The only difference between MSCOCO and MSCOCOReduced lies in the above. Besides that, every operation is the same, therefore there should be no need to override the constructor (or any other function for that matter). Maybe I could modify the MSCOCO constructor to accept a dictionary and do any necessary pruning (like removing categories from the dataset) in there instead.

Suggestions are welcome as always.

@ahundt
Copy link

ahundt commented May 23, 2017

I'd have it be a "private" (leading underscore) member function that can be called from the constructor, but otherwise that sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants