Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): linux/amd64 platform issue in docker compose #3436

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

AritraDey-Dev
Copy link
Contributor

@AritraDey-Dev AritraDey-Dev commented Feb 12, 2025

fixes #3415

Description

Fix Docker container pull errors on linux/arm64/v8.

Motivation and Context

Some images lack arm64 support; forcing amd64 works but breaks RabbitMQ.

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix
  • New feature
  • Breaking change

Checklist

  • Requires doc update
  • Added to CITATION.cff
  • Updated CHANGELOG
  • Updated docs
  • Read CONTRIBUTING
  • Added tests
  • All tests passed

@@ -3,6 +3,7 @@ services:
# webserver to handle all traffic. This can use let's encrypt to generate a SSL cert.
traefik:
image: "traefik:v2.9"
platform: linux/amd64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not all images need platform, only those that don't have an arm component.

@@ -73,6 +75,7 @@ services:
# ----------------------------------------------------------------------
bety:
image: pecan/bety:${BETY_VERSION:-latest}
platform: linux/amd64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has arm

Copy link
Member

@robkooper robkooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check to see what images (most) need amd64

@AritraDey-Dev
Copy link
Contributor Author

check to see what images (most) need amd64

@robkooper yes i have fixed this.It's working fine on my side.Could you please review this?

Copy link
Contributor

@Sweetdevil144 Sweetdevil144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm if my comments about restart is correct? Other than that everything else seems good to me.

@AritraDey-Dev
Copy link
Contributor Author

@Sweetdevil144 Can you verify if any changes required now?

@AritraDey-Dev
Copy link
Contributor Author

@robkooper i have added linux/amd64 for all services that need it. Please check if anything else needs to be improved before proceeding with docker-compose up.

Copy link
Collaborator

@allgandalf allgandalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AritraDey-Dev your branch is out of date with the base branch can you please fix it

@allgandalf allgandalf self-assigned this Feb 19, 2025
@allgandalf allgandalf self-requested a review February 19, 2025 12:54
@AritraDey-Dev
Copy link
Contributor Author

@AritraDey-Dev your branch is out of date with the base branch can you please fix it

yes i have updated it.

@dlebauer
Copy link
Member

@allgandalf and @robkooper have your requested changes been addressed?

@robkooper
Copy link
Member

I think we can merge, at least this way people can run the code on a Mac silicon.

@AritraDey-Dev
Copy link
Contributor Author

I think we can merge, at least this way people can run the code on a Mac silicon.

@allgandalf @robkooper Yes I think it can be merged as this works fine.

@robkooper robkooper merged commit 72e09bc into PecanProject:develop Feb 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Pull failure : arm64
5 participants