Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/block #225

Merged
merged 4 commits into from
Feb 2, 2025
Merged

Feature/block #225

merged 4 commits into from
Feb 2, 2025

Conversation

JTHesse
Copy link
Collaborator

@JTHesse JTHesse commented Feb 2, 2025

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a unit and/or fullscale test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure unit and fullscale tests pass.
  • DO make sure not to introduce any compiler warnings.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to PeriLab's overall architecture.

@JTHesse JTHesse merged commit 101dc78 into main Feb 2, 2025
3 checks passed
@JTHesse JTHesse deleted the feature/blockID branch February 2, 2025 11:21
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 90.58824% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.03%. Comparing base (4a9140f) to head (ce3387a).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...rc/Support/Parameters/parameter_handling_blocks.jl 79.31% 6 Missing ⚠️
src/IO/mesh_data.jl 90.47% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
- Coverage   90.11%   90.03%   -0.09%     
==========================================
  Files          75       75              
  Lines        6467     6522      +55     
==========================================
+ Hits         5828     5872      +44     
- Misses        639      650      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants