Skip to content

IsLine graphical issues, and a crash #1564

@mevitar

Description

@mevitar

Description

IsLine=yes is bugged for air units, being cut off near the target.
IsLine=yes doesn't always break properly if the unit stops attacking. Sometimes it doesn't break even as it stops attacking.

Here are gifs to visualise the problem:

Image

Image

Finally, when a unit with airstrike weapon is spammable and airstrikes are used repeatedly thorough the game, the likelyhood of a seemingly random crash increases (the crash below was caused by AirstrikeTarget not being cleared up).
https://drive.google.com/file/d/1xd3PoLCVYi60-u0V2jbiQue97VGWkg5t

Conditions to reproduce

No response

INI code

[TargetPainter]
Damage=0
ROF=1
ROF.RandomDelay=0
Range=11
Projectile=InvisibleVeryHigh
Warhead=AirstrikeFlare
OmniFire=yes
FireWhileMoving=no
MigAttackCursor=yes
IsLine=yes
Ammo=0

Steps to reproduce

  1. Start attacking a building
  2. Move the unit away
  3. If the line will not stop be drawn even if it moves to the other side of the map
  4. Order the unit to attack something else and the line immediately dissappears (at least in most cases)

Expected behaviour

The line should be drawn properly when used by air units.
The line should disconnect immediately after the attack stops, whether the unit simply moves away or stops attacking

Actual behaviour

The line is cut off when used by air units.
The line might not break if the unit moves away.

Additional context

No response

Checklist

  • The issue is not introduced by Phobos or any other engine extension, such as Ares, Kratos etc.
  • The issue wasn't fixed in the most recent version of Ares/Phobos yet.
  • I agree to elaborate the details if requested and provide thorough testing if the bugfix is implemented.
  • I added a very descriptive title to this issue.
  • I used the GitHub search and read the issue list to find a similar issue and didn't find it.
  • I have attached as much information as possible (screenshots, gifs, videos, debug and exception logs, etc).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions