Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE03: VALIDATE DATA CELL APPROPRIATE WITH TITLE COLUMN #13

Open
nnh53 opened this issue Apr 5, 2024 · 14 comments
Open

BE03: VALIDATE DATA CELL APPROPRIATE WITH TITLE COLUMN #13

nnh53 opened this issue Apr 5, 2024 · 14 comments
Assignees

Comments

@nnh53
Copy link
Member

nnh53 commented Apr 5, 2024

(US-03)

  • Must be done after BE02: Compare the title of column with the properties of product in system #6

  • Description:

    • Check the format of the cell compare to the title
      • exp: title: "loại", data: "áo" -> correct
      • exp: title: "tiền", data: "vnd" -> correct
      • exp: title: "price", data: "$" -> correct
      • exp: title: "loại", data: "13$" -> wrong
  • Approval Standards:

    • BE03.1
    • BE03.2
    • BE03.3
    • BE03.4
    • BE03.5
    • BE03.6
    • BE03.7
    • BE03.8
    • BE03.9
    • BE03.10
    • BE03.11
    • BE03.12
@nnh53 nnh53 assigned nnh53 and lcaohoanq and unassigned nnh53 Apr 5, 2024
@nnh53
Copy link
Member Author

nnh53 commented Apr 5, 2024

Image

  • Frontend need 3 list after this function: addNewRowList, updateRowList, ErrorRowList

@nnh53
Copy link
Member Author

nnh53 commented Apr 5, 2024

Image

@nnh53
Copy link
Member Author

nnh53 commented Apr 5, 2024

  • Dòng trống xử lý sao
    Image

@lcaohoanq
Copy link
Contributor

Image

  • Frontend need 3 list after this function: addNewRowList, updateRowList, ErrorRowList

@nnh53
I don't really understand what you mean, does this my require as well or you just notify for FE team

@lcaohoanq
Copy link
Contributor

@nnh53
#6 not done yet, can i do on my own generated fake data?

  • Employees Dreame.vi.xlsx
    image
  • Products Dreame.en.xlsx
    image

@nnh53
Copy link
Member Author

nnh53 commented Apr 15, 2024

@lcaohoanq do what ever u can to the task, urge @huy1707developer to do #6 faster

@lcaohoanq
Copy link
Contributor

@nnh53
Does this issues can be divide to smaller, the validate requirement is huge large, i don't know how to start with

  • As my demo data for the Products Dreame.en.xlsx
    image
  • The data type of data when read file can be a string, number base on xlsx default, does i need to check the data type as well, the requirement do not specify this (i'm do not have the legit data, now just on demo and when i can get the real data?)

Requirement

  • exp: title: "loại", data: "áo" -> correct
    • Now with demo of Product Dreame.en.xlsx and Employees Dreame.vi.xlsx, will have other file type also, i mean when loại -> áo, product (may be split in smaller like vaccum cleaner, robot,... ), nhân viên (admin, manager, dev, sales,...), i need to group all these data
  • exp: title: "tiền", data: "vnd" -> correct
    • Which is the data in Price column ($99.99 or 99,99 only), (100.000 VND or 100.000 VNĐ or 100.000 only)
  • exp: title: "price", data: "$" -> correct
    • The price column when see in excel it become: $99.99 but when read file it only 99.99, mean that the currency are handling by excel as well
  • exp: title: "loại", data: "13$" -> wrong
    • As above, the legit data we still not have, demo for this is huge difficult

@nnh53
Copy link
Member Author

nnh53 commented Apr 22, 2024

@lcaohoanq yes, in the next breakdown metting we will discuss about this

@hoangday185
Copy link

For non-mandatory data fields, if the data field is empty, the empty string is returned, otherwise it is checked as usual

@nnh53
Copy link
Member Author

nnh53 commented Apr 23, 2024

  • Break down to multiple smaller task

@hoangday185
Copy link

hoangday185 commented Apr 23, 2024

We have to manage objects like model and manufacturer. When we add a new object in the excel file, we will ask the user if they want to add a new one. If not, ignore that product. If so, popup and add it. #35#27

@nnh53 nnh53 changed the title BE03: Validate data cell appropriate with the title column BE03(): Validate data cell appropriate with the title column Apr 24, 2024
@nnh53 nnh53 changed the title BE03(): Validate data cell appropriate with the title column BE03: Validate data cell appropriate with the title column Apr 24, 2024
@nnh53 nnh53 changed the title BE03: Validate data cell appropriate with the title column BE03: VALIDATE DATA CELL APPROPRIATE WITH TITLE COLUMN Apr 25, 2024
@lcaohoanq
Copy link
Contributor

lcaohoanq commented Apr 27, 2024

@nnh53 @hoangday185 @huy1707developer

  • The title will be lower case only, instead of capitalize the first word

Image

  • Sample data here

Image

Products Dreame.en.xlsx

Image

Products Dreame.vi.xlsx

@nnh53
Copy link
Member Author

nnh53 commented Apr 27, 2024

No, let the user choice however they want, we will lower in BE code @lcaohoanq

@lcaohoanq
Copy link
Contributor

No, let the user choice however they want, we will lower in BE code @lcaohoanq

Yes, base on user choice, i just want to notify everyone that i will work on the sample data fix to lower case the title

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants