From 3665d8a9196cc43061ffc9ba22991e038874b61b Mon Sep 17 00:00:00 2001 From: Pierre <128218103+PierreTrehet@users.noreply.github.com> Date: Fri, 13 Jun 2025 18:33:11 +0200 Subject: [PATCH 1/7] Update signing UI with modal summary --- src/popup/Signing/Extrinsic.tsx | 27 ++++++++++++++++++++++++--- src/popup/Signing/index.tsx | 2 +- 2 files changed, 25 insertions(+), 4 deletions(-) diff --git a/src/popup/Signing/Extrinsic.tsx b/src/popup/Signing/Extrinsic.tsx index 6dbc925..4da69ba 100644 --- a/src/popup/Signing/Extrinsic.tsx +++ b/src/popup/Signing/Extrinsic.tsx @@ -17,6 +17,7 @@ import { PORT_EXTENSION } from "../../extension-base/defaults"; import { useTheme } from "../context/ThemeContext"; import { transactionUtils } from "@reef-chain/util-lib"; import { ProviderContext } from "../contexts"; +import Uik from "@reef-chain/ui-kit"; interface Decoded { args: AnyJson | null; @@ -160,9 +161,27 @@ function Extrinsic({ }, [provider]) const { isDarkMode } = useTheme(); + const [showDetails, setShowDetails] = useState(false); + return ( - - +
+
+ {signatureResponse?.methodName && ( +
+ {signatureResponse.methodName.split("(")[0]} +
+ )} + {signatureResponse?.info &&
{signatureResponse.info}
} + setShowDetails(!showDetails)} + className="mt-2" + /> +
+ {showDetails && ( +
+ {url !== PORT_EXTENSION && ( @@ -218,7 +237,9 @@ function Extrinsic({ -
From{mortalityAsString(era, blockNumber)}
+ + )} + ); } diff --git a/src/popup/Signing/index.tsx b/src/popup/Signing/index.tsx index f27d6b4..56bd15a 100644 --- a/src/popup/Signing/index.tsx +++ b/src/popup/Signing/index.tsx @@ -65,7 +65,7 @@ export const Signing = ({ requests }: Props): JSX.Element => { /> )} -
+
Date: Fri, 13 Jun 2025 18:49:34 +0200 Subject: [PATCH 2/7] Adjust signing modal layout --- src/popup/Signing/Extrinsic.tsx | 4 ++-- src/popup/Signing/index.tsx | 12 ++---------- 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/src/popup/Signing/Extrinsic.tsx b/src/popup/Signing/Extrinsic.tsx index 4da69ba..b5b8660 100644 --- a/src/popup/Signing/Extrinsic.tsx +++ b/src/popup/Signing/Extrinsic.tsx @@ -165,7 +165,7 @@ function Extrinsic({ return (
-
+
{signatureResponse?.methodName && (
{signatureResponse.methodName.split("(")[0]} @@ -176,7 +176,7 @@ function Extrinsic({ text={showDetails ? "Hide details" : "Show details"} size="small" onClick={() => setShowDetails(!showDetails)} - className="mt-2" + className="uik-button--small mt-2" />
{showDetails && ( diff --git a/src/popup/Signing/index.tsx b/src/popup/Signing/index.tsx index 56bd15a..1aee800 100644 --- a/src/popup/Signing/index.tsx +++ b/src/popup/Signing/index.tsx @@ -7,16 +7,13 @@ import type { SignerPayloadJSON } from "@polkadot/types/types"; import { SigningRequest } from "../../extension-base/background/types"; import Request from "./Request"; import RequestIndex from "../RequestIndex"; -import Account from "../Accounts/Account"; import { Loading } from "../components/Loading"; -import { useTheme } from "../context/ThemeContext"; interface Props { requests: SigningRequest[]; } export const Signing = ({ requests }: Props): JSX.Element => { - const { isDarkMode } = useTheme(); const [requestIndex, setRequestIndex] = useState(0); const [isTransaction, setIsTransaction] = useState(false); @@ -54,7 +51,7 @@ export const Signing = ({ requests }: Props): JSX.Element => { return requests.length && requests[requestIndex] ? ( <> -
+
{isTransaction ? "Transaction" : "Sign message"} {requests.length > 1 && ( { /> )}
-
- +
Date: Fri, 13 Jun 2025 18:56:38 +0200 Subject: [PATCH 3/7] Remove mx-4 from modal body --- src/popup/Signing/Extrinsic.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/popup/Signing/Extrinsic.tsx b/src/popup/Signing/Extrinsic.tsx index b5b8660..da39370 100644 --- a/src/popup/Signing/Extrinsic.tsx +++ b/src/popup/Signing/Extrinsic.tsx @@ -165,7 +165,7 @@ function Extrinsic({ return (
-
+
{signatureResponse?.methodName && (
{signatureResponse.methodName.split("(")[0]} From e5b175402f3374a07585182e2b74481d7e3b4164 Mon Sep 17 00:00:00 2001 From: Pierre <128218103+PierreTrehet@users.noreply.github.com> Date: Fri, 13 Jun 2025 19:08:04 +0200 Subject: [PATCH 4/7] Use confirm popup container --- src/popup/Signing/Extrinsic.tsx | 2 +- src/popup/Signing/index.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/popup/Signing/Extrinsic.tsx b/src/popup/Signing/Extrinsic.tsx index da39370..94adccc 100644 --- a/src/popup/Signing/Extrinsic.tsx +++ b/src/popup/Signing/Extrinsic.tsx @@ -165,7 +165,7 @@ function Extrinsic({ return (
-
+
{signatureResponse?.methodName && (
{signatureResponse.methodName.split("(")[0]} diff --git a/src/popup/Signing/index.tsx b/src/popup/Signing/index.tsx index 1aee800..747c4b4 100644 --- a/src/popup/Signing/index.tsx +++ b/src/popup/Signing/index.tsx @@ -62,7 +62,7 @@ export const Signing = ({ requests }: Props): JSX.Element => { /> )}
-
+
Date: Fri, 13 Jun 2025 19:27:30 +0200 Subject: [PATCH 5/7] Show transaction summary without confirm container --- src/popup/Signing/Extrinsic.tsx | 2 +- src/popup/Signing/index.tsx | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/popup/Signing/Extrinsic.tsx b/src/popup/Signing/Extrinsic.tsx index 94adccc..a247aa4 100644 --- a/src/popup/Signing/Extrinsic.tsx +++ b/src/popup/Signing/Extrinsic.tsx @@ -165,7 +165,7 @@ function Extrinsic({ return (
-
+
{signatureResponse?.methodName && (
{signatureResponse.methodName.split("(")[0]} diff --git a/src/popup/Signing/index.tsx b/src/popup/Signing/index.tsx index 747c4b4..62902f1 100644 --- a/src/popup/Signing/index.tsx +++ b/src/popup/Signing/index.tsx @@ -7,6 +7,7 @@ import type { SignerPayloadJSON } from "@polkadot/types/types"; import { SigningRequest } from "../../extension-base/background/types"; import Request from "./Request"; import RequestIndex from "../RequestIndex"; +import Account from "../Accounts/Account"; import { Loading } from "../components/Loading"; interface Props { @@ -62,7 +63,12 @@ export const Signing = ({ requests }: Props): JSX.Element => { /> )}
-
+
+ Date: Fri, 13 Jun 2025 19:34:52 +0200 Subject: [PATCH 6/7] Remove remaining mx-4 classes --- src/popup/RequestIndex.tsx | 2 +- src/popup/Signing/Extrinsic.tsx | 2 +- src/popup/Signing/Request.tsx | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/popup/RequestIndex.tsx b/src/popup/RequestIndex.tsx index bf4274e..531b01c 100644 --- a/src/popup/RequestIndex.tsx +++ b/src/popup/RequestIndex.tsx @@ -46,7 +46,7 @@ function RequestIndex({ icon={faArrowAltCircleLeft as IconProp} onClick={prevClick} /> -
+
{index + 1} /{totalItems}
diff --git a/src/popup/Signing/Extrinsic.tsx b/src/popup/Signing/Extrinsic.tsx index a247aa4..e31a564 100644 --- a/src/popup/Signing/Extrinsic.tsx +++ b/src/popup/Signing/Extrinsic.tsx @@ -165,7 +165,7 @@ function Extrinsic({ return (
-
+
{signatureResponse?.methodName && (
{signatureResponse.methodName.split("(")[0]} diff --git a/src/popup/Signing/Request.tsx b/src/popup/Signing/Request.tsx index 6cb0d1d..3cf69e5 100644 --- a/src/popup/Signing/Request.tsx +++ b/src/popup/Signing/Request.tsx @@ -145,7 +145,7 @@ export default function Request({ ) : hexBytes !== null ? ( ) : null} -
+
{isFirst && isLocked && (
From 90569f4aa9cf6bfae02cf1e8b8ade0ddac6da0c0 Mon Sep 17 00:00:00 2001 From: Pierre <128218103+PierreTrehet@users.noreply.github.com> Date: Fri, 13 Jun 2025 19:44:11 +0200 Subject: [PATCH 7/7] Adjust signing popup layout --- src/popup/Signing/Request.tsx | 2 +- src/popup/Signing/index.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/popup/Signing/Request.tsx b/src/popup/Signing/Request.tsx index 3cf69e5..6cb0d1d 100644 --- a/src/popup/Signing/Request.tsx +++ b/src/popup/Signing/Request.tsx @@ -145,7 +145,7 @@ export default function Request({ ) : hexBytes !== null ? ( ) : null} -
+
{isFirst && isLocked && (
diff --git a/src/popup/Signing/index.tsx b/src/popup/Signing/index.tsx index 62902f1..cc9f126 100644 --- a/src/popup/Signing/index.tsx +++ b/src/popup/Signing/index.tsx @@ -63,7 +63,7 @@ export const Signing = ({ requests }: Props): JSX.Element => { /> )}
-
+