Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort realms alphabetically in dropdown on signup page #1549

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

varCepheid
Copy link
Collaborator

closes #1548
Title says it all.

@varCepheid varCepheid added the enhancement Adds a new feature or meets a request. label Sep 29, 2024
@varCepheid varCepheid self-assigned this Sep 29, 2024
@varCepheid varCepheid requested a review from calebeby September 29, 2024 03:47
@varCepheid
Copy link
Collaborator Author

There are some changes to package-lock.json because I installed a newer patch of NPM. Would you like me not to do that in the future?

src/routes/signup.tsx Outdated Show resolved Hide resolved
@varCepheid
Copy link
Collaborator Author

I noticed that getRealms is also being called in the report-editor page and the users page. In the users table, the user can sort by any column of the table, so the order it gets the realms is unimportant. On the report-editor page, the only place where it uses the realms is if the user is a super-admin, in which case it gives an option to replace the user who created the report with any other user in any realm, using a dropdown that groups users by realm. It doesn't seem to be sorting the groups alphabetically, but the code is a little over my head, and it seems like a very niche use-case. Do you want me to try to address that?

@calebeby
Copy link
Member

I think this PR is good as-is, thanks for making the suggested change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adds a new feature or meets a request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sort realms alphabetically in sign-up dropdown
2 participants