-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build links for instanced pipelines don't work #148
Comments
Hello @jamiegosling, thanks for reporting. Lines 336 to 340 in 9328bb4
What is the cogito version you are using? You can see it as the first line output of any step:
|
Hi @marco-m-pix4d, Looks like we're on the latest version:
Looking at it I wonder if it needs a function to convert the JSON instance vars into URL parameters in the format |
@marco-m-pix4d can it be that it changed depending on the Concourse version? this is still "experimental" feature subject to changes.
@jamiegosling just curious a bit, which Concourse version you are using? |
Possible. In any case, this makes me think that in general from Cogito we could hit a Concourse endpoint that returns its version and log it, this could be helpful for troubleshooting in general... |
Yes, we have it in header of every request.
|
Ah even better! Good catch. |
@aliculPix4D we are using Concourse v7.10.0 |
My attempt to fix this: #153 |
We use Instanced Pipelines, and the build links we get for them in GitHub don't appear to work. Here is an example of a link from cogito:
https://concourse/teams/teamname/pipelines/pipeline_name/jobs/job_name/builds/5?vars=%7B%22DEPLOYMENTID%22%3A%222%22%2C%22DESC%22%3A%22Daily+tests+for+Preprod+2%22%2C%22TITLE%22%3A%22PREPROD+TESTS%22%7D
an example of a working link for the above build
https://concourse/teams/teamname/pipelines/pipeline_name/jobs/job_name/builds/5?vars.DEPLOYMENTID=%222%22&vars.DESC=%22Daily%20tests%20for%20Preprod%202%22&vars.TITLE=%22PREPROD%20TESTS%22
The text was updated successfully, but these errors were encountered: