From 040053240e9523ea8938aff4726979f1dfa6c642 Mon Sep 17 00:00:00 2001
From: Xin Liu <livid@v2ex.com>
Date: Thu, 11 Jul 2024 00:01:49 -0700
Subject: [PATCH] Improve the attachment check logic in MyPlanetModel: if any
 aggregated attachment is missing, do not publish the article.

---
 Planet/Entities/MyPlanetModel.swift | 45 ++++++++++++++++++++++++++++-
 Planet/versioning.xcconfig          |  2 +-
 2 files changed, 45 insertions(+), 2 deletions(-)

diff --git a/Planet/Entities/MyPlanetModel.swift b/Planet/Entities/MyPlanetModel.swift
index 7c7aae73..98d35743 100644
--- a/Planet/Entities/MyPlanetModel.swift
+++ b/Planet/Entities/MyPlanetModel.swift
@@ -1452,7 +1452,50 @@ class MyPlanetModel: Equatable, Hashable, Identifiable, ObservableObject, Codabl
         let allArticles = articles.map { item in
             return item.publicArticle
         }
-        let publicArticles = articles.filter { $0.articleType == .blog }.map { $0.publicArticle }
+        var publicArticles = articles.filter { $0.articleType == .blog }.map { $0.publicArticle }
+        // Check if all public articles have complete attachments
+        debugPrint("About to check all attachments for planet \(name)")
+        for article in articles {
+            var shouldRemoveArticle = false
+            if let attachments = article.attachments {
+                debugPrint("Attachments check: \(article.id) should have \(attachments.count) attachments")
+                for attachment in attachments {
+                    var shouldRemove = false
+                    let attachmentPath = article.publicBasePath.appendingPathComponent(attachment)
+                    if !FileManager.default.fileExists(atPath: attachmentPath.path) {
+                        shouldRemoveArticle = true
+                        debugPrint("Attachments check: \(attachmentPath) not found")
+                    } else {
+                        let fileSize = try FileManager.default.attributesOfItem(atPath: attachmentPath.path)[.size] as? Int ?? 0
+                        if fileSize == 0 {
+                            debugPrint("Attachments check: \(attachmentPath) is empty")
+                            shouldRemove = true
+                        } else {
+                            if fileSize < 1000 {
+                                let fileDataString = try String(contentsOf: attachmentPath)
+                                if fileDataString.contains("no link named") && fileDataString.contains("under") {
+                                    debugPrint("Attachments check: \(attachmentPath) is a broken link")
+                                    shouldRemove = true
+                                } else {
+                                    debugPrint("Attachments check: \(attachmentPath) is OK")
+                                }
+                            } else {
+                                debugPrint("Attachments check: \(attachmentPath) is OK")
+                            }
+                        }
+                    }
+                    if shouldRemove {
+                        shouldRemoveArticle = true
+                        debugPrint("Attachments check: \(attachmentPath) is broken, removing")
+                        try FileManager.default.removeItem(at: attachmentPath)
+                    }
+                }
+            }
+            if shouldRemoveArticle {
+                debugPrint("Attachments check: \(article.id) has broken attachments, removing article from public site")
+                publicArticles.removeAll { $0.id == article.id }
+            }
+        }
         let publicPlanet = PublicPlanetModel(
             id: id,
             name: name,
diff --git a/Planet/versioning.xcconfig b/Planet/versioning.xcconfig
index ca1a48d1..8d1891d8 100644
--- a/Planet/versioning.xcconfig
+++ b/Planet/versioning.xcconfig
@@ -1 +1 @@
-CURRENT_PROJECT_VERSION = 2128
+CURRENT_PROJECT_VERSION = 2129