Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Solution to SplineXYZCoil in CoilSets #1148

Open
dpanici opened this issue Jul 24, 2024 · 2 comments
Open

Better Solution to SplineXYZCoil in CoilSets #1148

dpanici opened this issue Jul 24, 2024 · 2 comments
Assignees
Labels
coil stuff relating to coils and coil optimization enhancement General label for enhancement. Please also tag with "Speed", "Interface", "Functionality", etc

Comments

@dpanici
Copy link
Collaborator

dpanici commented Jul 24, 2024

Vectorize over knots and intervals instead of enforcing knots and intervals , but we need to make knots and intervals part of params possibly (in the compute function definition)

See curve winding surface PR (I think I do it somewhere in the compute fxns not the objective, but I did it in a way that is jax-differentiable), I think you can use get_params in the build method of the objective, then in the compute, update that params dict with the passed-in params dict, that way the non-optimizable params are present when computing the objective.

@YigitElma
Copy link
Collaborator

Better Solution to #1136

@dpanici
Copy link
Collaborator Author

dpanici commented Aug 13, 2024

@dpanici update with link to code in the CWS PR

@dpanici dpanici added enhancement General label for enhancement. Please also tag with "Speed", "Interface", "Functionality", etc coil stuff relating to coils and coil optimization labels Aug 13, 2024
@dpanici dpanici changed the title Better Solution to #1136 Better Solution to SplineXYZCoil in CoilSets Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coil stuff relating to coils and coil optimization enhancement General label for enhancement. Please also tag with "Speed", "Interface", "Functionality", etc
Projects
None yet
Development

No branches or pull requests

3 participants