Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change equations to match physics #1176

Closed
unalmis opened this issue Aug 12, 2024 · 2 comments · Fixed by #1177
Closed

Change equations to match physics #1176

unalmis opened this issue Aug 12, 2024 · 2 comments · Fixed by #1177
Assignees
Labels
documentation Add documentation or better warnings etc.

Comments

@unalmis
Copy link
Collaborator

unalmis commented Aug 12, 2024

I would prefer to keep stuff like this as independent quantities. For stuff like g_rt and g_tr, those are the same both physically and numerically, independent of how we parameterize or discretize things.

Stuff like theta_PEST_tt and lambda_tt are actually different things physically, its just that they happen to the same numerically because we define theta_PEST = theta + lambda, but in theory other relations are possible and equally valid physically.

Originally posted by @f0uriest in #1175 (comment)

@unalmis
Copy link
Collaborator Author

unalmis commented Aug 12, 2024

In that case I have created the linked branch to reflect that. @f0uriest you confirm with a thumbs up / thumbs down whether you still want to create new compute functions that just do data["theta_PEST_z"] = data["lambda_z"]; return data ? This could be a couple thousand lines of code. Maybe also @ddudt since related to #1171.

@unalmis unalmis added the documentation Add documentation or better warnings etc. label Aug 12, 2024
@f0uriest
Copy link
Member

Ideally yes, I'd like to keep them separate, but we don't have to do everything at once. The main point was to not remove existing things and replace them with aliases (and as we add new things try to keep to that convention).

@unalmis unalmis self-assigned this Aug 17, 2024
unalmis added a commit that referenced this issue Aug 27, 2024
… angle (#1177)

Resolves #1176.

- [x] Update equations to use poloidal and toroidal angles rather than a
particular choice of stream function. No changes were made in places
where a particular choice of stream function is necessary to simplify
the computation.
- [x] Genearlizes boozer fit for arbitrary toroidal angle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Add documentation or better warnings etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants