Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full grid is overriden to symmetric grid #1313

Open
unalmis opened this issue Oct 20, 2024 · 1 comment
Open

Full grid is overriden to symmetric grid #1313

unalmis opened this issue Oct 20, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@unalmis
Copy link
Collaborator

unalmis commented Oct 20, 2024

When I make a compute function with

resolution_requirement="tz",
grid_requirement={"coordinates": "rtz", "is_meshgrid": True, "sym": False}

and use eq.compute for that function, the full grid I supply is overridden to a symmetric one. The compute function catches this error, complaining that a full grid is required.

In general, I should not need to specify override_grid=False here because I am fine with the grid being overriden when computing dependencies.

@unalmis unalmis changed the title Override grid ignores new grid requirement Full grid is overriden to symmetric grid Oct 20, 2024
@unalmis
Copy link
Collaborator Author

unalmis commented Oct 20, 2024

#1094 is a good branch to resolve this because it has quantities that require non-symmetric grids

@unalmis unalmis added the good first issue Good for newcomers label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant