Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ReactiveFeignClient adds path + "/" even if not necessary #332

Closed
islayeri opened this issue Dec 30, 2020 · 3 comments · Fixed by #339
Closed

@ReactiveFeignClient adds path + "/" even if not necessary #332

islayeri opened this issue Dec 30, 2020 · 3 comments · Fixed by #339

Comments

@islayeri
Copy link

Copying issue from kptfh#13 as it is still reproducible.

Final request path: ReactiveFeignClient.path + "/" + GetMapping.value
If GetMapping.value is default "/" is added anyway.
The behavior is different from FeignClient

Example:
@GetMapping(produces = MediaType.APPLICATION_JSON_UTF8_VALUE) Result get(@RequestParam(value = "param") );

@ReactiveFeignClient( path = "/my/path", )

Expected (non reactive feign-client behaviour):
/my/path?param=...
Real: additional '/' is added after ReactiveFeignClient.path
/my/path/?param=...

@rmatec
Copy link

rmatec commented Jan 20, 2021

Hi,

Thanks for fixing this. It was a show stopper for me. May I ask when you plan to release this fix?

@kptfh
Copy link
Collaborator

kptfh commented Jan 20, 2021

@rmatec
Copy link

rmatec commented Jan 20, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants