Feature/more tests #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndling and add support for Protobuf transport
This commit modifies the RPC disconnect method in the `echo.go` file to add support for reconnecting. It checks if the data parameter contains the string "reconnect" and disconnects the client with reconnection if true. Otherwise, it disconnects the client without reconnection. This enhancement improves the flexibility of the RPC disconnect functionality.
This commit updates the timeouts in the smoke_test.dart file to improve RPC testing. The previous timeouts were [1000, 100, 10, 100, 0], and they have been changed to [200, 50, 10, 25, 0]. This change ensures that the RPC requests are sent and received within the specified time intervals, enhancing the reliability and performance of the RPC functionality.
…est.dart This commit refactors the WebSocket handling and adds support for Protobuf transport in the smoke_test.dart file. It improves the RPC testing by updating the timeouts from [1000, 100, 10, 100, 0] to [200, 50, 10, 25, 0]. Additionally, it introduces reconnecting functionality in the RPC disconnect method in the echo.go file. The client is now disconnected with reconnection if the data parameter contains the string "reconnect". This enhancement improves the flexibility and reliability of the RPC functionality.
This commit updates the async_test.dart file to improve caching performance. It introduces a cache timer that clears the cache after 5 minutes of inactivity. This enhancement ensures that the cache remains up-to-date and avoids unnecessary memory usage.
This commit updates the launch configuration in the `.vscode/launch.json` file to set up debugging for the benchmark app instead of the example app. The `name` field is changed to "[Flutter] Benchmark" and the `cwd` field is updated to "${workspaceFolder}/benchmark". This change ensures that the correct app is launched and debugged when running the benchmark.
This commit updates the UI of the benchmark app to improve the user experience when setting the payload size and message count. It adds labels for the payload size and message count sliders, making it easier for users to understand their purpose. Additionally, it adjusts the layout and padding of the UI elements for better visual consistency. These changes enhance the usability of the benchmark app and make it more intuitive for users to configure the payload size and message count.
This commit updates the `BenchmarkController` class to use an abstract base class called `BenchmarkControllerBase`. This change allows for better code organization and separation of concerns. The `BenchmarkControllerBase` class contains common properties and methods that are shared by different benchmark implementations. By using an abstract base class, it becomes easier to add new benchmark implementations in the future. This refactor improves the maintainability and extensibility of the codebase.
This commit refactors the benchmark app to improve the user interface and status handling. It updates the UI to enhance the user experience when setting the payload size and message count, adding labels for the sliders and adjusting the layout for better visual consistency. Additionally, it introduces a new status property in the `BenchmarkControllerBase` class to track the status of the benchmark, allowing for better communication with the user. These changes improve the usability and clarity of the benchmark app.
refactor: Add constants for JWT token and WebSocket endpoint This commit adds two constants to the benchmark app: `tokenHmacSecretKey` for the JWT token HMAC key and `defaultEndpoint` for the default WebSocket connection endpoint. These constants provide a centralized and easily configurable way to manage these values throughout the app. By using constants, it improves code readability and maintainability.
This commit adds the HelpTab component to the benchmark app UI. The HelpTab provides helpful information and instructions for using the app, including steps for setting up the benchmark environment and running the benchmark. This addition enhances the usability and user experience of the benchmark app.
This commit updates the `firebase.json` file to modify the hosting ignore rules. The previous rules were spread across multiple lines, which made the file harder to read and maintain. This change consolidates the ignore rules into a single line, improving the readability and maintainability of the file.
This commit updates the titles of the benchmark app to include "Spinify" for better branding consistency. The app titles were changed from "Benchmark" to "Spinify Benchmark" in both the main app and the app bar. This change improves the branding and recognition of the app.
This commit updates the timestamp in the pubspec.yaml.g.dart file to reflect the correct build date and time. The previous values were incorrect and have been corrected to ensure accurate tracking of build information. This change improves the reliability and integrity of the build process.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 13431830 | Triggered | Generic Password | 837daed | benchmark/docker-compose.yml | View secret |
| 13431830 | Triggered | Generic Password | 76d7d22 | benchmark/lib/src/help_tab.dart | View secret |
| 13431831 | Triggered | Generic High Entropy Secret | 837daed | benchmark/docker-compose.yml | View secret |
| 13431831 | Triggered | Generic High Entropy Secret | 837daed | benchmark/lib/src/constant.dart | View secret |
| 13431831 | Triggered | Generic High Entropy Secret | 76d7d22 | benchmark/lib/src/help_tab.dart | View secret |
| 13431832 | Triggered | Generic High Entropy Secret | 837daed | benchmark/docker-compose.yml | View secret |
| 13431832 | Triggered | Generic High Entropy Secret | 76d7d22 | benchmark/lib/src/help_tab.dart | View secret |
| 13431833 | Triggered | Generic High Entropy Secret | 837daed | benchmark/docker-compose.yml | View secret |
| 13431833 | Triggered | Generic High Entropy Secret | 76d7d22 | benchmark/lib/src/help_tab.dart | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.