Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom export views in synthese #2968

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Conversation

TheoLechemia
Copy link
Member

@TheoLechemia TheoLechemia commented Mar 18, 2024

@TheoLechemia
Copy link
Member Author

TheoLechemia commented Mar 18, 2024

ça donne ça :
image

Du coup ça rend inutile les paramètres suivants :

EXPORT_ID_SYNTHESE_COL,
EXPORT_ID_DIGITISER_COL,
EXPORT_OBSERVERS_COL,
EXPORT_GEOJSON_4326_COL,
EXPORT_GEOJSON_LOCAL_COL

ça vous va si je les marque comme dépréciés et qu'on les enlève dans une 2.15 ?

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 97.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.53%. Comparing base (7bf6332) to head (65d1381).
Report is 2 commits behind head on develop.

Files Patch % Lines
backend/geonature/utils/config_schema.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2968      +/-   ##
===========================================
+ Coverage    78.45%   78.53%   +0.08%     
===========================================
  Files           89       89              
  Lines         7204     7236      +32     
===========================================
+ Hits          5652     5683      +31     
- Misses        1552     1553       +1     
Flag Coverage Δ
pytest 78.53% <97.50%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@camillemonchicourt
Copy link
Member

OK très bien.
Oui il faudra dire dans la prochaine release, qu'il ne sera prochainement plus possible de modifier la vue d'export par défaut et qu'on va supprimer ces paramètres.
Mais donc plutôt les supprimer dans une version 2.16 ou 2.17.
Et revoir la doc sur la modification des exports de la Synthèse.

@TheoLechemia TheoLechemia changed the title Possibilty to add custom export views in synthese - closes #2955 Add custom export views in synthese Mar 18, 2024
@TheoLechemia
Copy link
Member Author

En fait on peut peut être garde le paramètre EXPORT_COLUMNS qui permet de limiter les colonnes de l'export (si on veut limiter les champs sans se faire d'export custo)

@jacquesfize jacquesfize added this to the 2.14.1 milestone Mar 18, 2024
@TheoLechemia TheoLechemia force-pushed the feat/synthese-export branch 2 times, most recently from 44c8764 to 570b7ba Compare March 20, 2024 11:02
@jacquesfize jacquesfize merged commit af7ffbe into develop Mar 26, 2024
9 checks passed
@jacquesfize jacquesfize deleted the feat/synthese-export branch March 26, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants