Utilize polymorphic_serialization instead of Metaclass to adjust annotations #127
Conversation
NeejWeej
requested review from
feussy,
hintse,
ptomecek and
timkpaine
as code owners
NeejWeej
force-pushed
the
nk/serialize_as_any_updates
branch
from
781d7a1 to
31bdbb6
Compare
pyproject.toml
Outdated
| "pandas", | ||
| "pyarrow", | ||
| "pydantic>=2.6,<3", | ||
| "pydantic>=2.35,<3", |
There was a problem hiding this comment.
wrong version specifier still
There was a problem hiding this comment.
Ah yup, I think that was the pydantic-core version where this came from.
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
NeejWeej
force-pushed
the
nk/serialize_as_any_updates
branch
from
31bdbb6 to
5367fd3
Compare
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
|
I think this is blocked by this: pydantic/pydantic#12382 Ex a build error. that occured: E pydantic_core._pydantic_core.PydanticSerializationError: Unable to serialize unknown type: <class 'ccflow.tests.test_base_serialize.MyEnum'> Even though MyEnum has a pydantic core schema defined (it's a ccflow enum) Notably, the above issue states: That first recommendation is what we currently do with the MetaClass, and apply the SerializeAsAny annotation to pydantic BaseModels here: https://github.com/Point72/ccflow/blob/main/ccflow/base.py#L117 
It seems we can't move off of that until these issues are addressed |
NeejWeej
changed the title
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
NeejWeej
force-pushed
the
nk/serialize_as_any_updates
branch
from
ff8c9e3 to
1ac3bd8
Compare
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
NeejWeej
changed the title
NeejWeej
changed the title
Utilize the
polymorphic_serializationflag introduced in this PR:pydantic/pydantic#12518
This PR will fail to build until a pydantic release has this feature in it.