Bug in Duplicate Task

[maxachis]

Current bug occurred with duplicate detection, forcing me to temporarily suspend the duplicate detection task:

Session is closed
Traceback (most recent call last):
  File "/app/src/core/tasks/operators/base.py", line 51, in run_task
    await self.inner_task_logic()
  File "/app/src/core/tasks/operators/url_duplicate/core.py", line 36, in inner_task_logic
    tdo.is_duplicate = await self.pdap_client.is_url_duplicate(tdo.url)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/src/pdap_api/client.py", line 84, in is_url_duplicate
    response_info = await self.access_manager.make_request(request_info)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pdap_access_manager/access_manager.py", line 223, in make_request
    async with method(**ri.kwargs()) as response:
  File "/usr/local/lib/python3.11/site-packages/aiohttp/client.py", line 1425, in __aenter__
    self._resp: _RetType = await self._coro
                           ^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/aiohttp/client.py", line 512, in _request
    raise RuntimeError("Session is closed")
RuntimeError: Session is closed

Will need to resolve and then re-enable the task.

[maxachis]

So I re-enabled without actually doing anything different, and the Duplicate Task worked fine.

As I understand it:

• Under normal logic, nothing should close the aiohttp ClientSession, except when the app is being shut down
• We do have some code that creates their own ClientSessions, rather than using the big daddy client session, which is sub-optimal, but not necessarily related to this. It is possible a closed session is being passed around. To avoid ambiguity, I should refactor so that only one ClientSession is used.

[maxachis]

Aha! I spoke too soon! There is a place in AgencyIdentification that creates a ClientSession, passes that to pdap access manager, and then exits, presumably terminating that as well. Identified and a PR created to address!