From 10a85938cdde771e893b81a249cd1a65afa5e7e2 Mon Sep 17 00:00:00 2001 From: Joshua Graber Date: Sun, 17 Dec 2023 17:37:04 -0500 Subject: [PATCH] chore: remove or modify miscellaneous comments --- release.config.cjs | 4 ++-- src/components/Nav/nav.spec.ts | 4 ++-- tools/testing/serializer.ts | 5 +---- 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/release.config.cjs b/release.config.cjs index c4a91ba..cd25d45 100644 --- a/release.config.cjs +++ b/release.config.cjs @@ -62,7 +62,7 @@ module.exports = { '@semantic-release/github', - /* TODO: Use either of the below strategies. + /* TODO: Use either of the below strategies to raise PR against `main` or commit directly to `main` *** */ // 6. Update version with new release PR raised against main (in lieu of direct commit for now) // If we're going to use this, it will require a shim. See errors in console. @@ -77,7 +77,7 @@ module.exports = { // ] - // TODO: Fix token so that /git will work + // TODO: Fix token // // 6. Update version with new release commit (must be called after /changelog and /npm) // [ // '@semantic-release/git', diff --git a/src/components/Nav/nav.spec.ts b/src/components/Nav/nav.spec.ts index 5bafb7d..c6b35ab 100644 --- a/src/components/Nav/nav.spec.ts +++ b/src/components/Nav/nav.spec.ts @@ -29,7 +29,7 @@ const base = { config: { warnHandler(msg, instance, trace) { if ( - // TODO: investigate these cases (happening anywhere nav is rendered) + // TODO: investigate these cases msg.includes('Invalid prop: type check failed for prop') || msg.includes('missing template') ) { @@ -62,7 +62,7 @@ describe('Nav component', () => { }); test('Renders mobile nav', () => { - // TODO: how to check? + // TODO: check this }); test('Renders empty nav when links are undefined', () => { diff --git a/tools/testing/serializer.ts b/tools/testing/serializer.ts index 0dc54b5..70ff990 100644 --- a/tools/testing/serializer.ts +++ b/tools/testing/serializer.ts @@ -2,9 +2,7 @@ /* c8 ignore next 30 */ import { print as _print } from 'jest-serializer-vue-tjw'; -// TODO: -// 1. Write tests -// 2. Fix typescript -- any type is not safe +// TODO: 1. Write tests, 2. Fix typescript -- any type is not safe const helpers = { isHtmlString: function (received: any) { @@ -31,4 +29,3 @@ export default { print, test, }; -// TODO: Devise a test for this, so that we don't need to add c8 declaration ignoring it (code is more or less boilerplate from c8 - https://github.com/tjw-lint/jest-serializer-vue-tjw/#using-with-vitest)