Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split runtime so version are individually typed + add missing count to Authorization #25

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Split runtime so version are individually typed + add missing count to Authorization #25

merged 2 commits into from
Sep 18, 2024

Conversation

F-OBrien
Copy link
Contributor

@F-OBrien F-OBrien commented Sep 18, 2024 •
edited
Loading

Description

  • Refactored the runtime api to make it more similar to the approach taken by the Polkadot api. see this as a reference example
  • added missing count parameter to the Authorization type

Breaking Changes

none

JIRA Link

N/A

Checklist

  • Updated the Readme.md (if required) ? N/A

polymath-eric
polymath-eric reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@polymath-eric polymath-eric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks more organized this way.

Not sure about the u34 type for count though, are you sure its not u32?

src/types/5.0.x.json Outdated Show resolved Hide resolved
@F-OBrien F-OBrien merged commit 65347f1 into main Sep 18, 2024
4 checks passed
@F-OBrien F-OBrien deleted the split-runtime branch September 18, 2024 15:31
@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version 5.12.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polymath-eric polymath-eric polymath-eric approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@F-OBrien @prashantasdeveloper @polymath-eric