Skip to content

Commit 20e3247

Browse files
authored
Merge pull request #97 from PopPool/refactor/#92-Replacing-Kingfisher-with-a-custom-image-caching-and-resizing-module
[REFACTOR] Kingfisher 기능을 대체하기 위한 ImageLoader 개발
2 parents e8d2883 + ec1848b commit 20e3247

File tree

11 files changed

+420
-245
lines changed

11 files changed

+420
-245
lines changed

Poppool/Poppool.xcodeproj/project.pbxproj

Lines changed: 21 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,8 @@
262262
0899526E2D0474340022AEF9 /* GetSearchPopUpListResponse.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0899526D2D0474340022AEF9 /* GetSearchPopUpListResponse.swift */; };
263263
089952732D0475E90022AEF9 /* SearchResultCountSection.swift in Sources */ = {isa = PBXBuildFile; fileRef = 089952722D0475E90022AEF9 /* SearchResultCountSection.swift */; };
264264
089952752D0475F20022AEF9 /* SearchResultCountSectionCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 089952742D0475F20022AEF9 /* SearchResultCountSectionCell.swift */; };
265+
089B4FD82D9A57AE00FC0CC3 /* ImageLoader.swift in Sources */ = {isa = PBXBuildFile; fileRef = 089B4FD72D9A57AE00FC0CC3 /* ImageLoader.swift */; };
266+
089B4FDF2D9A8F9A00FC0CC3 /* MemoryStorage.swift in Sources */ = {isa = PBXBuildFile; fileRef = 089B4FDE2D9A8F9A00FC0CC3 /* MemoryStorage.swift */; };
265267
08A2E46C2D15BC5000102313 /* CommentLikeRequestDTO.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08A2E46B2D15BC5000102313 /* CommentLikeRequestDTO.swift */; };
266268
08A2E4792D1B06A300102313 /* ImageDetailView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08A2E4782D1B06A300102313 /* ImageDetailView.swift */; };
267269
08A2E47B2D1B06AA00102313 /* ImageDetailController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08A2E47A2D1B06AA00102313 /* ImageDetailController.swift */; };
@@ -343,6 +345,7 @@
343345
08CBEA3A2D3FABE100248007 /* ToastView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08CBEA392D3FABE100248007 /* ToastView.swift */; };
344346
08CBEA3C2D3FABED00248007 /* BookMarkToastView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08CBEA3B2D3FABED00248007 /* BookMarkToastView.swift */; };
345347
08CBEA3E2D3FF6A100248007 /* PopUpCardView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08CBEA3D2D3FF6A100248007 /* PopUpCardView.swift */; };
348+
08CFD3922D9BDE99004CDD50 /* DiskStorage.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08CFD3912D9BDE99004CDD50 /* DiskStorage.swift */; };
346349
08DC61F32CF75037002A2F44 /* KeyChainService.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08DC61F22CF75037002A2F44 /* KeyChainService.swift */; };
347350
08DC61F52CF765B5002A2F44 /* UserDefaultService.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08DC61F42CF765B5002A2F44 /* UserDefaultService.swift */; };
348351
08DC61F82CF76843002A2F44 /* SignUpCompleteView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08DC61F72CF76843002A2F44 /* SignUpCompleteView.swift */; };
@@ -461,7 +464,6 @@
461464
BDCA41CA2CF35AC1005EECF6 /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = BDCA41C92CF35AC1005EECF6 /* Assets.xcassets */; };
462465
BDCA41CD2CF35AC1005EECF6 /* Base in Resources */ = {isa = PBXBuildFile; fileRef = BDCA41CC2CF35AC1005EECF6 /* Base */; };
463466
BDCA41F22CF35D0D005EECF6 /* SnapKit in Frameworks */ = {isa = PBXBuildFile; productRef = BDCA41F12CF35D0D005EECF6 /* SnapKit */; };
464-
BDCA41F52CF35D33005EECF6 /* Kingfisher in Frameworks */ = {isa = PBXBuildFile; productRef = BDCA41F42CF35D33005EECF6 /* Kingfisher */; };
465467
BDCA41F82CF35D9A005EECF6 /* RxSwift in Frameworks */ = {isa = PBXBuildFile; productRef = BDCA41F72CF35D9A005EECF6 /* RxSwift */; };
466468
BDCA41FE2CF35EE7005EECF6 /* ReactorKit in Frameworks */ = {isa = PBXBuildFile; productRef = BDCA41FD2CF35EE7005EECF6 /* ReactorKit */; };
467469
BDCA42012CF35EFE005EECF6 /* RxKeyboard in Frameworks */ = {isa = PBXBuildFile; productRef = BDCA42002CF35EFE005EECF6 /* RxKeyboard */; };
@@ -728,6 +730,8 @@
728730
0899526D2D0474340022AEF9 /* GetSearchPopUpListResponse.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = GetSearchPopUpListResponse.swift; sourceTree = "<group>"; };
729731
089952722D0475E90022AEF9 /* SearchResultCountSection.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SearchResultCountSection.swift; sourceTree = "<group>"; };
730732
089952742D0475F20022AEF9 /* SearchResultCountSectionCell.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SearchResultCountSectionCell.swift; sourceTree = "<group>"; };
733+
089B4FD72D9A57AE00FC0CC3 /* ImageLoader.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ImageLoader.swift; sourceTree = "<group>"; };
734+
089B4FDE2D9A8F9A00FC0CC3 /* MemoryStorage.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MemoryStorage.swift; sourceTree = "<group>"; };
731735
08A2E46B2D15BC5000102313 /* CommentLikeRequestDTO.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CommentLikeRequestDTO.swift; sourceTree = "<group>"; };
732736
08A2E4782D1B06A300102313 /* ImageDetailView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ImageDetailView.swift; sourceTree = "<group>"; };
733737
08A2E47A2D1B06AA00102313 /* ImageDetailController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ImageDetailController.swift; sourceTree = "<group>"; };
@@ -809,6 +813,7 @@
809813
08CBEA392D3FABE100248007 /* ToastView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ToastView.swift; sourceTree = "<group>"; };
810814
08CBEA3B2D3FABED00248007 /* BookMarkToastView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BookMarkToastView.swift; sourceTree = "<group>"; };
811815
08CBEA3D2D3FF6A100248007 /* PopUpCardView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PopUpCardView.swift; sourceTree = "<group>"; };
816+
08CFD3912D9BDE99004CDD50 /* DiskStorage.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DiskStorage.swift; sourceTree = "<group>"; };
812817
08DC61F22CF75037002A2F44 /* KeyChainService.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = KeyChainService.swift; sourceTree = "<group>"; };
813818
08DC61F42CF765B5002A2F44 /* UserDefaultService.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = UserDefaultService.swift; sourceTree = "<group>"; };
814819
08DC61F72CF76843002A2F44 /* SignUpCompleteView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SignUpCompleteView.swift; sourceTree = "<group>"; };
@@ -931,7 +936,6 @@
931936
files = (
932937
BDCA41F82CF35D9A005EECF6 /* RxSwift in Frameworks */,
933938
BDCA420D2CF35FD2005EECF6 /* RxGesture in Frameworks */,
934-
BDCA41F52CF35D33005EECF6 /* Kingfisher in Frameworks */,
935939
BDCA42072CF35FA6005EECF6 /* Tabman in Frameworks */,
936940
BDCA42042CF35F76005EECF6 /* PanModal in Frameworks */,
937941
082197A12D426DCB0054094A /* Then in Frameworks */,
@@ -1427,6 +1431,7 @@
14271431
083A25A02CF3623C0099B58E /* Infrastructure */ = {
14281432
isa = PBXGroup;
14291433
children = (
1434+
089B4FD62D9A576F00FC0CC3 /* ImageLoader */,
14301435
0841BA832CF9F61500049E31 /* PreSignedService */,
14311436
083A25B12CF362670099B58E /* NetworkLayer */,
14321437
08DC61F42CF765B5002A2F44 /* UserDefaultService.swift */,
@@ -2244,6 +2249,16 @@
22442249
path = View;
22452250
sourceTree = "<group>";
22462251
};
2252+
089B4FD62D9A576F00FC0CC3 /* ImageLoader */ = {
2253+
isa = PBXGroup;
2254+
children = (
2255+
089B4FD72D9A57AE00FC0CC3 /* ImageLoader.swift */,
2256+
089B4FDE2D9A8F9A00FC0CC3 /* MemoryStorage.swift */,
2257+
08CFD3912D9BDE99004CDD50 /* DiskStorage.swift */,
2258+
);
2259+
path = ImageLoader;
2260+
sourceTree = "<group>";
2261+
};
22472262
08A2E4772D1B069300102313 /* ImageDetail */ = {
22482263
isa = PBXGroup;
22492264
children = (
@@ -2988,7 +3003,6 @@
29883003
name = Poppool;
29893004
packageProductDependencies = (
29903005
BDCA41F12CF35D0D005EECF6 /* SnapKit */,
2991-
BDCA41F42CF35D33005EECF6 /* Kingfisher */,
29923006
BDCA41F72CF35D9A005EECF6 /* RxSwift */,
29933007
BDCA41FD2CF35EE7005EECF6 /* ReactorKit */,
29943008
BDCA42002CF35EFE005EECF6 /* RxKeyboard */,
@@ -3037,7 +3051,6 @@
30373051
mainGroup = BDCA41B42CF35AC0005EECF6;
30383052
packageReferences = (
30393053
BDCA41F02CF35D0D005EECF6 /* XCRemoteSwiftPackageReference "SnapKit" */,
3040-
BDCA41F32CF35D33005EECF6 /* XCRemoteSwiftPackageReference "Kingfisher" */,
30413054
BDCA41F62CF35D9A005EECF6 /* XCRemoteSwiftPackageReference "RxSwift" */,
30423055
BDCA41FC2CF35EE7005EECF6 /* XCRemoteSwiftPackageReference "ReactorKit" */,
30433056
BDCA41FF2CF35EFE005EECF6 /* XCRemoteSwiftPackageReference "RxKeyboard" */,
@@ -3190,11 +3203,13 @@
31903203
4E685EDB2D12CEB6001EF91C /* MapAPIEndpoint.swift in Sources */,
31913204
086F89CC2D1E42B000CA4FC9 /* CommentUserBlockController.swift in Sources */,
31923205
08DC62032CF8AC06002A2F44 /* HomeView.swift in Sources */,
3206+
089B4FD82D9A57AE00FC0CC3 /* ImageLoader.swift in Sources */,
31933207
BD9103622CF6149D00BBCCAE /* LoginResponseDTO.swift in Sources */,
31943208
083C86642D0EC4A5003F441C /* InstaCommentAddReactor.swift in Sources */,
31953209
08DE8A3F2D54DCC40049BCAC /* MyCommentedPopUpGridSection.swift in Sources */,
31963210
081898C52D30AEF40067BF01 /* GetMyProfileResponse.swift in Sources */,
31973211
BD9103922CF6166800BBCCAE /* SplashView.swift in Sources */,
3212+
089B4FDF2D9A8F9A00FC0CC3 /* MemoryStorage.swift in Sources */,
31983213
0899526E2D0474340022AEF9 /* GetSearchPopUpListResponse.swift in Sources */,
31993214
08B191392CF366680057BC04 /* UITableViewCell+.swift in Sources */,
32003215
08A2E48F2D1BF6E500102313 /* CommentListView.swift in Sources */,
@@ -3344,6 +3359,8 @@
33443359
BD9103652CF6149D00BBCCAE /* HomeAPIEndpoint.swift in Sources */,
33453360
086DD8E32CFF356300B97D3B /* HomeCardGridSection.swift in Sources */,
33463361
0841BABE2CFB5AA600049E31 /* Date?+.swift in Sources */,
3362+
083A258D2CF361F90099B58E /* ConventionCollectionViewCell.swift in Sources */,
3363+
08CFD3922D9BDE99004CDD50 /* DiskStorage.swift in Sources */,
33473364
4E685EE12D12CEB6001EF91C /* StoreListReactor.swift in Sources */,
33483365
4E685EE52D12CEB6001EF91C /* MapMarker.swift in Sources */,
33493366
081898FB2D33D9320067BF01 /* GetBlockUserListResponseDTO.swift in Sources */,
@@ -3866,14 +3883,6 @@
38663883
minimumVersion = 5.7.1;
38673884
};
38683885
};
3869-
BDCA41F32CF35D33005EECF6 /* XCRemoteSwiftPackageReference "Kingfisher" */ = {
3870-
isa = XCRemoteSwiftPackageReference;
3871-
repositoryURL = "https://github.com/onevcat/Kingfisher.git";
3872-
requirement = {
3873-
kind = upToNextMajorVersion;
3874-
minimumVersion = 8.1.1;
3875-
};
3876-
};
38773886
BDCA41F62CF35D9A005EECF6 /* XCRemoteSwiftPackageReference "RxSwift" */ = {
38783887
isa = XCRemoteSwiftPackageReference;
38793888
repositoryURL = "https://github.com/ReactiveX/RxSwift.git";
@@ -3993,11 +4002,6 @@
39934002
package = BDCA41F02CF35D0D005EECF6 /* XCRemoteSwiftPackageReference "SnapKit" */;
39944003
productName = SnapKit;
39954004
};
3996-
BDCA41F42CF35D33005EECF6 /* Kingfisher */ = {
3997-
isa = XCSwiftPackageProductDependency;
3998-
package = BDCA41F32CF35D33005EECF6 /* XCRemoteSwiftPackageReference "Kingfisher" */;
3999-
productName = Kingfisher;
4000-
};
40014005
BDCA41F72CF35D9A005EECF6 /* RxSwift */ = {
40024006
isa = XCSwiftPackageProductDependency;
40034007
package = BDCA41F62CF35D9A005EECF6 /* XCRemoteSwiftPackageReference "RxSwift" */;

Poppool/Poppool.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

Lines changed: 0 additions & 177 deletions
This file was deleted.

0 commit comments

Comments
 (0)