Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty error message in some code paths #3906

Open
steve-chavez opened this issue Feb 9, 2025 · 0 comments
Open

Empty error message in some code paths #3906

steve-chavez opened this issue Feb 9, 2025 · 0 comments
Labels
difficulty: beginner Pure Haskell task hygiene cleanup or refactoring messages user-facing error/informative messages

Comments

@steve-chavez
Copy link
Member

One last concern, we are still using NotFound error in a couple places, which returns an empty error json:

postgrest/src/PostgREST/ApiRequest/Types.hs

Line 82 in e2dd435

| NotFound

postgrest/src/PostgREST/Error.hs

Line 135 in e2dd435

toJSON NotFound = JSON.object []

This seems fine for now, but maybe should be improved later (add error msg, details etc) for better UX?

Originally posted by @taimoorzaeem in #3869 (comment)
@steve-chavez steve-chavez added hygiene cleanup or refactoring messages user-facing error/informative messages difficulty: beginner Pure Haskell task labels Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: beginner Pure Haskell task hygiene cleanup or refactoring messages user-facing error/informative messages
Milestone
No milestone
Development

No branches or pull requests
1 participant
@steve-chavez