Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate secret command in yargs #74

Open
GeorgeCadwallader opened this issue Mar 24, 2024 · 3 comments
Open

Recreate secret command in yargs #74

GeorgeCadwallader opened this issue Mar 24, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@GeorgeCadwallader
Copy link
Member

Problem to solve

We need to recreate the secret command in version 2 of the app.

Proposal

This command should work the same as it did in version 1.

We're not looking at supporting anymore OS types with this command, purely to replicate the same functionality from version 1 to 2.

The idea really is that we will advise people pass the token in manually by using the CT_TOKEN variable. As they would do when integrating Conventional Tools in CI.

@GeorgeCadwallader GeorgeCadwallader added the enhancement New feature or request label Mar 24, 2024
@GeorgeCadwallader GeorgeCadwallader added this to the 2.x milestone Mar 24, 2024
@GeorgeCadwallader GeorgeCadwallader self-assigned this Mar 24, 2024
@GeorgeCadwallader
Copy link
Member Author

@AdeAttwood What do we think about this one?

Been playing around with this and it might be best to just leave this one I think.

As we discussed previously, we want to push the use of passing CT_TOKEN in instead. Also with pushing the idea that Conventional Tools should be used in CI (when CT_TOKEN is required).

Also with not wanting to use execa (which is how this is done in 1.x) and child processes I think it might be best to leave this.

@AdeAttwood
Copy link
Collaborator

I think it might be best to leave this.

I don't mind. If we are on the fence about removing this feature in V2 then we should leave if off the list, if it becomes a probity we can add it back in. I don't think this is a big feature and will not be a significant amount of work to build in. We will still need to abstract the credentials logic, maybe bundle it into source control host interface like we have the source control.

@GeorgeCadwallader
Copy link
Member Author

I think it might be best to leave this.

I don't mind. If we are on the fence about removing this feature in V2 then we should leave if off the list, if it becomes a probity we can add it back in. I don't think this is a big feature and will not be a significant amount of work to build in. We will still need to abstract the credentials logic, maybe bundle it into source control host interface like we have the source control.

Cool, I'll move this into the Backlog milestone and we can move back in to 2.x if we think it's a requirement.

@GeorgeCadwallader GeorgeCadwallader modified the milestones: 2.x, Backlog Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants